Project

General

Profile

Bug #11648

Unexpected report for Send inventories to CMDB after #11257

Added by Janos Mattyasovszky about 2 months ago. Updated about 1 hour ago.

Status:
Released
Priority:
N/A
Category:
Initial promises & sys tech
Target version:
Target version (plugin):
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Very Small
Priority:
61

Description

In #11257 a flag was introduced to disable send-clean.sh and a n/a output log was additionally made.

This apparently conflicts with the case if no reports are to be sent, because then you get double reporting:

E| n/a           DistributePolicy          Send inventories to CMDB                     Sending inventories has been disabled
E| compliant     DistributePolicy          Send inventories to CMDB                     No inventory to send

unexpected_Send_to_CMDB.png (22 KB) Janos Mattyasovszky, 2017-10-23 10:58


Subtasks

Bug #11847: Mismatched report and metadatat in distribute policyReleasedNicolas CHARLES


Related issues

Related to Rudder - User story #11257: Do not send inventory if a forwarder/uploader daemon exists Released

Associated revisions

Revision a2cfb8de
Added by Nicolas CHARLES 24 days ago

Fixes #11648: Unexpected report for Send inventories to CMDB after #11257

History

#1 Updated by Janos Mattyasovszky about 2 months ago

  • File deleted (unexpected_Send_to_CMDB.png)

#3 Updated by Janos Mattyasovszky about 2 months ago

  • Description updated (diff)

#4 Updated by Janos Mattyasovszky about 2 months ago

This fixed it for me on top of latest nightly (rudder-techniques-4.1.8.rc1.git201710220155-1.SLES.11):

From 99f497ece40b2ce1e101e1ecad2fde443ec2a4bc Mon Sep 17 00:00:00 2001
From: "root user (CLI)" <root@localhost>
Date: Mon, 23 Oct 2017 10:59:49 +0200
Subject: [PATCH] Fixes #11648: Double reporting for disabled inventory sending

---
 techniques/system/distributePolicy/1.0/propagatePromises.st | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/techniques/system/distributePolicy/1.0/propagatePromises.st b/techniques/sy
stem/distributePolicy/1.0/propagatePromises.st
index d2dfabc..867d3f0 100644
--- a/techniques/system/distributePolicy/1.0/propagatePromises.st
+++ b/techniques/system/distributePolicy/1.0/propagatePromises.st
@@ -286,7 +286,7 @@ bundle agent sendInventoryToCmdb
     pass3.rudder_inventory_processing_error::
       "any" usebundle => rudder_common_report("DistributePolicy", "result_error", "&TRA
CKINGKEY&", "Send inventories to CMDB", "None", "Some incoming inventories could not be
sent to the inventory API");

-    pass3.((root_server|role_rudder_relay_top|role_rudder_relay_promises_only).!rudder_
inventory_processing_repaired.!rudder_inventory_processing_error)::
+    pass3.((root_server|role_rudder_relay_top|role_rudder_relay_promises_only).!rudder_
inventory_processing_repaired.!rudder_inventory_processing_error.!disable_upload)::
       "any" usebundle => rudder_common_report("DistributePolicy", "result_success", "&T
RACKINGKEY&", "Send inventories to CMDB", "None", "No inventory to send");

     pass3.(rudder_inventory_relay_repaired.!rudder_inventory_relay_error)::
--
2.14.2

#5 Updated by Janos Mattyasovszky about 2 months ago

  • Related to User story #11257: Do not send inventory if a forwarder/uploader daemon exists added

#6 Updated by Benoît PECCATTE about 2 months ago

  • Effort required set to Very Small
  • Priority changed from 32 to 49

#7 Updated by Benoît PECCATTE about 1 month ago

  • Priority changed from 49 to 61

#8 Updated by Nicolas CHARLES about 1 month ago

  • Target version set to 3.1.25

#9 Updated by Nicolas CHARLES about 1 month ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES

#10 Updated by Nicolas CHARLES about 1 month ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Alexis MOUSSET
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1218

#11 Updated by Nicolas CHARLES 24 days ago

  • Status changed from Pending technical review to Pending release

#12 Updated by Vincent MEMBRÉ about 2 hours ago

  • Category changed from Techniques to Initial promises & sys tech

#13 Updated by Vincent MEMBRÉ about 1 hour ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.1.25, 4.1.9 and 4.2.3 which were released today.

Also available in: Atom PDF