[rudder-users] Post-modification command in enforce file content technique

[Jonathan Clarke]

Hi Michael,

On 17/08/12 17:20, Michael Gliwinski wrote:
> Hi All,
>
> The post-modification command in enforce file content technique
> (checkGenericFileContent/3.0) is currently only executed if content was
> enforced/added, but not when deletion or regex replacement was made.  Is this
> by design?  I.e. would it be undesirable to also run it after deletion or
> replacement?
>
> I can work around it by also inserting a comment line, but was wondering if it
> would make sense to change it to also run in other scenarios?
>
> If so, I'll file a bug and can work on a patch.

That's definitely a bug. I agree the post-modification hook should be 
executed after *any* modifiction (thus it's change). Well spotted!

Please go ahead and file a bug. The best way to submit a patch is via a 
Github Pull Request - just ask if you need some guidance on that, I'm 
happy to help :)

Thanks!
Jonathan
-- 
------------------------------------------------------------------------
*Jonathan CLARKE*
/CTO - Directeur technique/
Normation <http://www.normation.com>
------------------------------------------------------------------------
*87 rue de Turbigo, 75003 Paris, France*
Telephone: 	+33 (0)1 83 62 41 24
Mobile: 	+33 (0)6 99 60 03 10
------------------------------------------------------------------------

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.rudder-project.org/pipermail/rudder-users/attachments/20120821/cabc5729/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: logo-square.png
Type: image/png
Size: 3503 bytes
Desc: not available
URL: <http://www.rudder-project.org/pipermail/rudder-users/attachments/20120821/cabc5729/attachment.png>