Enhancement #9576: Ensure that the python-jinja2 library is present - Rudder - Issue Tracker

Actions

Copy link

Enhancement #9576

open

Ensure that the python-jinja2 library is present

Added by Alexandre Anriot over 7 years ago. Updated about 2 years ago.

Status:

New

Priority:

N/A

Assignee:

Alexis Mousset

Category:

Generic methods

Target version:

Ideas (not version specific)

Pull Request:

UX impact:

Suggestion strength:

Want - This would make my life a lot easier but I can manage without

User visibility:

Operational - other Techniques | Technique editor | Rudder settings

Effort required:

Small

Name check:

Fix check:

Regression:

Description

Hello,

At the moment, the rendering of a Jinja2 template fails on a server without python-jinja2.

Could it be possible to add the library either:

- In the dependencies of the rudder-agent package ;
- Through a promise, when it's needed.

Thanks.

Actions

Copy link

Updated by Jonathan CLARKE over 7 years ago

Project changed from Rudder to 41

Alexandre Anriot wrote:

Hello,

At the moment, the rendering of a Jinja2 template fails on a server without python-jinja2.

Could it be possible to add the library either:

- In the dependencies of the rudder-agent package ;

We'd rather avoid having rudder-agent depend on Python for just one generic method. We already require Perl (for the inventory), and would like to limit requirements.

- Through a promise, when it's needed.

This could be a good alternative. Maybe a call to package_present("python-jinja2") in the template jinja2 ncf method?

Actions

Copy link

Updated by Alexis Mousset over 7 years ago

Category set to Generic methods

Actions

Copy link

Updated by François ARMAND over 7 years ago

Assignee set to Alexis Mousset

Actions

Copy link

Updated by Alexis Mousset about 7 years ago

Target version set to 1.0

Actions

Copy link

Updated by Alexis Mousset almost 7 years ago

Target version changed from 1.0 to 1.1

Actions

Copy link

Updated by Vincent MEMBRÉ over 6 years ago

Target version changed from 1.1 to 4.1.9

Actions

Copy link

Updated by Vincent MEMBRÉ over 6 years ago

Target version changed from 4.1.9 to 4.1.10

Actions

Copy link

Updated by Vincent MEMBRÉ about 6 years ago

Target version changed from 4.1.10 to 4.1.11

Actions

Copy link

Updated by Florian Heigl about 6 years ago

make it a -recommend for the package?

- Through a promise, when it's needed.

should at least be automatic: IF a NCF technique is using the method, have a specific error to be returned if missing, or add a correct flag in the system techniques.
It should not just hit a wall and let the user figure out that "oh, no sorry, you could click this but it won't work"

Personally, I think rudder has to sort it out. NCF is the users' interface, he should not be required to debug (and log on) to the system.
For me the warning in the docs was good and on time, but really, let the system techniques or NCF sort it out.

Actions

Copy link

#10

Updated by François ARMAND about 6 years ago

Suggestion strength set to Want - This would make my life a lot easier but I can manage without
User visibility set to Operational - other Techniques | Technique editor | Rudder settings
Effort required set to Small

The recommand is a good idea. We could list all non mandatory dependencies as such, and explains for what they are recommanded.

The need to see the system log is also a problem. We should at bare minimum at least report on the compliance report "Error: missing mandatory dependency on the system: XXXX. Please install python-jinja2 (or whatever)" so that the user can immediately know how to solve the problem without having to explore.

Actions

Copy link

#11