Project

General

Profile

Actions

User story #9204

closed

User story #1808: Add an Audit mode to Rudder: only check properties, no modification on nodes

User story #8924: Policy mode API (Global, Directive, Node)

Clean up unused NodeXXXModified events

Added by François ARMAND over 7 years ago. Updated over 7 years ago.

Status:
Released
Priority:
1
Category:
Web - Maintenance
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

With the parent ticket, we are merging several disjoint events related to node into a new "node properties" event.

For now, the implementation is able to read both old events and new ones, and so we are assure that old archives and events in the DB are still correctly readable.
But we need to do a migration so that we have a release from which we can say "starting now, we don't have to care about old disjoint node properties". And so be able to remove the code diffenitly after a couple of version;

UPDATE: read comments to see why actually, we don't need that migration.


Related issues 1 (0 open1 closed)

Related to Rudder - Architecture #9202: Clean old fileFormat migration and fileFormat numbering policyReleasedVincent MEMBRÉ2016-10-03Actions
Actions #1

Updated by François ARMAND over 7 years ago

  • Target version set to 4.0.0~rc2
Actions #2

Updated by François ARMAND over 7 years ago

  • Related to Architecture #9202: Clean old fileFormat migration and fileFormat numbering policy added
Actions #3

Updated by François ARMAND over 7 years ago

With some more looking, we don't need a migration:

- the 3.2 eventlog details (the XML part) for node ("NodeHeartbeatModified", "NodePropertiesModified", "NodeAgentRunPeriodModified") have the same structure "NodeModified", so that the unserialisation of a NodeModified correctly unserialize the 3 old one ;
- in 4.0, we are only producing "ModifyNodeEventType" eventType, whereas in 3.2 we were producing "ModifyNodeHeartbeatEventType", "ModifyNodePropertiesEventType" and "ModifyNodeAgentRunPeriodEventType". So we just have to say that now, the 3 old eventType for node are mapped to the new "ModifyNodeEventType"

With that, we don't have to change the file format nor the eventType. The only modification if to have ModifyNodeEventType mapped from 4 string in place of one - something that we can afford to maintain.

Actions #4

Updated by François ARMAND over 7 years ago

  • Subject changed from Update XML fileFormat to 7 and add a migration to Clean up unused NodeXXXModified events
  • Description updated (diff)
Actions #5

Updated by François ARMAND over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1233
Actions #6

Updated by François ARMAND over 7 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #7

Updated by Benoît PECCATTE over 7 years ago

  • Target version changed from 4.0.0~rc2 to 318
Actions #8

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 318 to 4.0.0~rc2
Actions #9

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.0.0~rc2 to 4.0.0~rc1
Actions #10

Updated by Alexis Mousset over 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.0.0 which was released the 10th November 2016.

Actions

Also available in: Atom PDF