Project

General

Profile

Bug #7984

Rudder commits empty changes into git

Added by Janos Mattyasovszky over 2 years ago. Updated about 2 months ago.

Status:
New
Priority:
N/A
Assignee:
-
Category:
Web - Config management
Target version:
Target version (plugin):
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Pull Request:
Priority:
18

Description

Rudder commits on every group update, even if there was actually no real change.
This pollutes the git history by adding empty commits.

Example:

rootserver:/var/rudder/configuration-repository # git log -v -p | head -n18
commit 0f2b885ab3c1fce71634aca6c9fd7010796d1d81
Author: rudder <email not set>
Date:   Fri Feb 26 12:03:24 2016 +0100

    Archive of node group with ID 'a2ab2334-f998-4ba0-bae9-ccbd11cf461d'

    Reason provided by user:
    Update group due to batch update of dynamic groups

commit aba6122a0cb4f9357d33068211ff1b6c0b416bdf
Author: rudder <email not set>
Date:   Fri Feb 26 12:03:10 2016 +0100

    Archive of node group with ID '97882090-29e2-43ab-b554-f40fb208bc8e'

    Reason provided by user:
    Update group due to batch update of dynamic groups

History

#1 Updated by François ARMAND over 2 years ago

  • Target version set to 2.11.20

Well, I'm not sure how git do that. You're totally right (and if I remember correctly the developper will, he thought that git wasn't doing empty commit).

#2 Updated by François ARMAND over 2 years ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND

#3 Updated by François ARMAND over 2 years ago

So, the good new is that we do take care of that case in the code: if(autoExportOnModify && optDiff.isDefined && !nodeGroup.isSystem) { //only persists if modification are present

The bad news is that I will need some more time to reproduce (I mean, reproduce it in a controled envirenment) and understand that one.

#4 Updated by François ARMAND over 2 years ago

Janos, did you have message like that:

Auto-archive git failure: not found in git added files: 'path/to/the/group/xml/file'. You can safelly ignore that warning if the file was already existing in Git and was not modified by that archive.

in /var/log/rudder/webapp/* for date corresponding for when the empty commit where created?

#5 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.20 to 2.11.21

#6 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.21 to 2.11.22

#7 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.22 to 2.11.23

#8 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.23 to 2.11.24

#9 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.24 to 308

#10 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 308 to 3.1.14

#11 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.14 to 3.1.15

#12 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.15 to 3.1.16

#13 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.16 to 3.1.17

#14 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.17 to 3.1.18

#15 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.18 to 3.1.19

#16 Updated by Jonathan CLARKE over 1 year ago

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Infrequent - complex configurations | third party integrations

#17 Updated by Benoît PECCATTE over 1 year ago

  • Priority set to 5

#18 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.19 to 3.1.20

#19 Updated by Jonathan CLARKE over 1 year ago

  • Status changed from In progress to New

#20 Updated by Jonathan CLARKE over 1 year ago

  • Assignee deleted (François ARMAND)

#21 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.20 to 3.1.21

#22 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.21 to 3.1.22

#23 Updated by Benoît PECCATTE about 1 year ago

  • Priority changed from 5 to 18

#24 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.22 to 3.1.23

#25 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.23 to 3.1.24

#26 Updated by Vincent MEMBRÉ 11 months ago

  • Target version changed from 3.1.24 to 3.1.25

#27 Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 3.1.25 to 387

#28 Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 387 to 4.1.10

#29 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 4.1.10 to 4.1.11

#30 Updated by Vincent MEMBRÉ 5 months ago

  • Target version changed from 4.1.11 to 4.1.12

#31 Updated by Vincent MEMBRÉ 4 months ago

  • Target version changed from 4.1.12 to 4.1.13

#32 Updated by Vincent MEMBRÉ 2 months ago

  • Target version changed from 4.1.13 to 4.1.14

#33 Updated by Benoît PECCATTE about 2 months ago

  • Target version changed from 4.1.14 to 4.1.15

Also available in: Atom PDF