Project

General

Profile

Actions

User story #7668

closed

rudder agent commands don't keep locks

Added by Benoît PECCATTE over 8 years ago. Updated about 7 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
-
Category:
Agent
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

We currently remove cfengine locks when we run rudder agent command manually.
This should be the reverse, ie keeping locks when we run without options and have a --force option to remove locks.

Actions #1

Updated by Jonathan CLARKE about 8 years ago

  • Translation missing: en.field_tag_list set to Quick and important
Actions #2

Updated by Jonathan CLARKE about 8 years ago

  • Tracker changed from User story to Bug
  • Subject changed from Keep locking in rudder agent to rudder agent commands don't keep locks
  • Reproduced set to No

This is a bug - we should never silently remove a lock.

The extra option (--force or whatever) could be a new feature for 3.3, but this definitely needs fixing in the next minor release.

Actions #3

Updated by Nicolas CHARLES about 8 years ago

Jonathan CLARKE wrote:

This is a bug - we should never silently remove a lock.

The extra option (--force or whatever) could be a new feature for 3.3, but this definitely needs fixing in the next minor release.

On the contrary, we should never run the agent manually without the lock - the risks of misbehavour is too big. Exemple, run twice agent without lock if the disable agent is set, and the second run will e a complete run.
This is a simple example, but it appl for everything (check if service is running and restart it if not, one first run it will be ok, on the second, the check will not be done, and the service will be restarted)

Actions #4

Updated by Jonathan CLARKE about 8 years ago

  • Assignee set to Alexis Mousset
Actions #5

Updated by Jonathan CLARKE about 8 years ago

  • Target version changed from 4.0.0~rc2 to 2.11.18
Actions #6

Updated by Jonathan CLARKE about 8 years ago

  • Target version changed from 2.11.18 to 3.0.13
Actions #7

Updated by Benoît PECCATTE about 8 years ago

This doesn't seem quick, we first need to understand how -K works and the implication of removing it.

Actions #8

Updated by Alexis Mousset about 8 years ago

  • Assignee deleted (Alexis Mousset)
Actions #9

Updated by Jonathan CLARKE about 8 years ago

  • Translation missing: en.field_tag_list deleted (Quick and important)

Benoît PECCATTE wrote:

This doesn't seem quick, we first need to understand how -K works and the implication of removing it.

Agreed. I thought this was about removing the "disable-agent" file.

Actions #10

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.0.13 to 3.0.14
Actions #11

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.0.14 to 3.0.15
Actions #12

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.0.15 to 3.0.16
Actions #13

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.0.16 to 3.0.17
Actions #14

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.0.17 to 2.11.23
Actions #15

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.23 to 302
Actions #16

Updated by Alexis Mousset almost 8 years ago

  • Target version changed from 302 to 3.1.12
Actions #17

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.12 to 3.1.13
Actions #18

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.13 to 3.1.14
Actions #19

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions #20

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions #21

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions #22

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.17 to 3.1.18
Actions #23

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.18 to 3.1.19
Actions #24

Updated by Benoît PECCATTE about 7 years ago

  • Tracker changed from Bug to User story
  • Status changed from New to Rejected

There is no reason to keep locks

Actions

Also available in: Atom PDF