Project

General

Profile

Bug #7622

Technique files contains UTF-8 chars (especially spaces)

Added by François ARMAND almost 2 years ago. Updated 6 months ago.

Status:
Released
Priority:
4
Category:
Techniques
Target version:
Target version (plugin):
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Priority:
0

Description

There is several techniques files containing UTF-8 chars, especially an UTF-8 space.

AFAIK, these chars are only in comments, but I only looked in system techniques.

The problem with a change to remove them will be in merge where it will be hard to know what is the correct space to get.

For information, the joined file is a list of such chars in system techniques.

utf8_spaces.patch Magnifier (10.4 KB) François ARMAND, 2015-12-16 14:51

Associated revisions

Revision 5f5cd238
Added by Jonathan CLARKE 7 months ago

Fixes #7622: Technique files contains UTF-8 chars (especially spaces)

History

#1 Updated by Jonathan CLARKE almost 2 years ago

  • Assignee set to François ARMAND

I understand the observation, but I don't understand the problem - you have filed this as a bug, so could you please explain the negative impact or perceived risk?

#2 Updated by Benoît PECCATTE over 1 year ago

  • Target version set to 2.11.21

#3 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 2.11.21 to 2.11.22

#4 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 2.11.22 to 2.11.23

#5 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 2.11.23 to 2.11.24

#6 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 2.11.24 to 308

#7 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 308 to 3.1.14

#8 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.14 to 3.1.15

#9 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.15 to 3.1.16

#10 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.16 to 3.1.17

#11 Updated by Vincent MEMBRÉ 12 months ago

  • Target version changed from 3.1.17 to 3.1.18

#12 Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 3.1.18 to 3.1.19

#13 Updated by François ARMAND 9 months ago

We had a problem with a cfengine command not doing what was expected due to a utf-8 space in place of a space.
We also add a problem with a third party scripts (python I believe?) that didn't parsed the content as expected due to them (it was breaking regex).

The bigger problem is that it breaks any regex apply on these file when done by human looking for space. It's surprising and deceving.

#14 Updated by Jonathan CLARKE 8 months ago

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Infrequent - complex configurations | third party integrations

#15 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 3.1.19 to 3.1.20
  • Priority set to 0

#16 Updated by Jonathan CLARKE 7 months ago

  • Status changed from Discussion to New

#17 Updated by Jonathan CLARKE 7 months ago

  • Assignee deleted (François ARMAND)

#18 Updated by Jonathan CLARKE 7 months ago

  • Status changed from New to In progress
  • Assignee set to Jonathan CLARKE

#19 Updated by Jonathan CLARKE 7 months ago

I will add a test to 'make test' to detect any such characters, at the same time as removing all existing ones. This should enable easy detection if they were to come back, or a merge were to reintroduce them.

#20 Updated by Jonathan CLARKE 7 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1139

#21 Updated by Jonathan CLARKE 7 months ago

  • Status changed from Pending technical review to Pending release

#22 Updated by Vincent MEMBRÉ 6 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.1.20, 4.0.5 and 4.1.2 which were released today.

Also available in: Atom PDF