Project

General

Profile

Actions

Bug #7605

closed

User story #7424: Add cfengine classes for each group of a node

Syntax error in generated rudder_groups bundle

Added by David Durieux over 8 years ago. Updated about 8 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When install 3.2-beta2 I have error on policies:

[2015-12-13 22:39:48] ERROR com.normation.rudder.services.policies.write.Cf3PromisesFileWriterServiceImpl - The generated promises are invalid: cf-promise check fails for promises generated at '/var/rudder/cfengine-community/inputs.new'<-Command to check generated promises is: '/var/rudder/cfengine-community/bin/cf-promises -f /var/rudder/cfengine-community/inputs.new/promises.cf'<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:13: error: syntax error<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-            ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:13: error: Expected promiser string, got 'by_uuid'<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-            ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:14: error: Expected ';', got '['<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-             ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:34: error: Expected ';', got ']'<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-                                 ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:64: error: Expected promiser string, got 'string'<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-                                                               ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:67: error: Expected ';', got '=>'<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-                                                                  ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:89: error: Expected attribute, got ',' (comma after promiser is not allowed since 3.5.0)<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-                                                                                        ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:64: error: Expected promiser string, got 'meta'<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                               ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:67: error: Expected ';', got '=>'<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                                  ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:69: error: Expected promiser string, got '{'<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                                    ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:81: error: Expected ';', got '"inventory"'<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                                                ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:82: error: Expected promiser string, got ','<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                                                 ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:113: error: Expected ';', got '"attribute_name=rudder_groups"'<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                                                                                ^<-Too many errors
[2015-12-13 22:39:48] ERROR com.normation.rudder.batch.AsyncDeploymentAgent$DeployerAgent - Error when updating policy, reason Cannot write configuration node <- The generated promises are invalid!errormessage!cf-promise check fails for promises generated at '/var/rudder/cfengine-community/inputs.new'<-Command to check generated promises is: '/var/rudder/cfengine-community/bin/cf-promises -f /var/rudder/cfengine-community/inputs.new/promises.cf'<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:13: error: syntax error<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-            ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:13: error: Expected promiser string, got 'by_uuid'<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-            ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:14: error: Expected ';', got '['<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-             ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:34: error: Expected ';', got ']'<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-                                 ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:64: error: Expected promiser string, got 'string'<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-                                                               ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:67: error: Expected ';', got '=>'<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-                                                                  ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:38:89: error: Expected attribute, got ',' (comma after promiser is not allowed since 3.5.0)<-      by_uuid["policyServer:root"]                        string => "Root policy server",<-                                                                                        ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:64: error: Expected promiser string, got 'meta'<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                               ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:67: error: Expected ';', got '=>'<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                                  ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:69: error: Expected promiser string, got '{'<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                                    ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:81: error: Expected ';', got '"inventory"'<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                                                ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:82: error: Expected promiser string, got ','<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                                                 ^<-/var/rudder/cfengine-community/inputs.new/common/1.0/rudder-groups.cf:39:113: error: Expected ';', got '"attribute_name=rudder_groups"'<-                                                            meta => { "inventory", "attribute_name=rudder_groups" };<-                                                                                                                ^<-Too many errors
Actions #1

Updated by David Durieux over 8 years ago

  • Target version set to 3.2.0~rc1
Actions #2

Updated by Nicolas CHARLES over 8 years ago

ok, generated code is invalid, as the quote are not at the proper location
it is

      by_uuid["policyServer:root"]                        string => "Root policy server",
                                                            meta => { "inventory", "attribute_name=rudder_groups" };

it should be
      "by_uuid[policyServer:root]"                        string => "Root policy server",
                                                            meta => { "inventory", "attribute_name=rudder_groups" };

Actions #3

Updated by Nicolas CHARLES over 8 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
Actions #4

Updated by Nicolas CHARLES over 8 years ago

  • Category set to Web - Config management
  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/998

https://github.com/Normation/rudder/pull/998

And I fixed the test to ensure it runned on maven

Actions #5

Updated by Nicolas CHARLES over 8 years ago

  • Pull Request changed from https://github.com/Normation/rudder/pull/998 to https://github.com/Normation/rudder/pull/999
Actions #6

Updated by Nicolas CHARLES over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #8

Updated by Alexis Mousset over 8 years ago

  • Subject changed from Policies errors to Syntax error in generated rudder_groups bundle
Actions #9

Updated by Benoît PECCATTE about 8 years ago

  • Parent task set to #7424
Actions #10

Updated by Benoît PECCATTE about 8 years ago

  • Status changed from Pending release to Released
Actions

Also available in: Atom PDF