Project

General

Profile

Actions

Bug #7365

closed

Bug #7356: Correct a warning in rudder compilation

There is scala compilation warning in Rudder 3.0

Added by François ARMAND over 8 years ago. Updated over 8 years ago.

Status:
Released
Priority:
2
Category:
Architecture - Code maintenance
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

There is some warning in compiling Rudder 3.0 :

These one, we can't do much, and they are here because of Guava:

[WARNING] warning: Class javax.annotation.Nullable not found - continuing with a stub.
[WARNING] warning: Class javax.annotation.Nullable not found - continuing with a stub.
[WARNING] warning: Class javax.annotation.Nullable not found - continuing with a stub.
[WARNING] warning: Class javax.annotation.Nullable not found - continuing with a stub.
[WARNING] warning: Class javax.annotation.Nullable not found - continuing with a stub.
[WARNING] warning: Class javax.annotation.CheckReturnValue not found - continuing with a stub.
[WARNING] warning: Class javax.annotation.Nullable not found - continuing with a stub.
[WARNING] warning: Class javax.annotation.Nullable not found - continuing with a stub.

This one, we can't do anything (I was the one reporting the problem):

[WARNING] warning: While parsing annotations in /home/fanf/.m2/repository/com/unboundid/unboundid-ldapsdk/2.3.6/unboundid-ldapsdk-2.3.6.jar(com/unboundid/util/ThreadSafetyLevel.class
), could not find COMPLETELY_THREADSAFE in enum object ThreadSafetyLevel.
[INFO] This is likely due to an implementation restriction: an annotation argument cannot refer to a member of the annotated class (SI-7014).

These one, we should be able to remove:

[WARNING] warning: there were 1 deprecation warning(s); re-run with -deprecation for details
[WARNING] warning: there were 2 unchecked warning(s); re-run with -unchecked for details
[WARNING] warning: there were 5 feature warning(s); re-run with -feature for details
[WARNING] warning: there were 2 deprecation warning(s); re-run with -deprecation for details
[WARNING] warning: there were 20 deprecation warning(s); re-run with -deprecation for details
[WARNING] warning: there were 12 feature warning(s); re-run with -feature for details

This one is "ok", but it may change in the future: remove it.

[WARNING] /home/fanf/java/workspaces/rudder-project/rudder/rudder-core/src/main/scala/com/normation/rudder/repository/jdbc/ExpectedReportsJdbcRepository.scala:964: warning: match may
 not be exhaustive.
[WARNING] It would fail on the following input: List(_)
[WARNING]         case t => t.sliding(2).map {
[WARNING]                                    ^

This one is clearly a problem:

[WARNING] /home/fanf/java/workspaces/rudder-project/rudder/rudder-web/src/main/scala/com/normation/rudder/web/snippet/administration/PropertiesManagement.scala:512: warning: a pure e
xpression does nothing in statement position; you may be omitting necessary parentheses
[WARNING]       "ok" 
[WARNING]       ^
Actions #1

Updated by François ARMAND over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/950
Actions #2

Updated by François ARMAND over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #4

Updated by Vincent MEMBRÉ over 8 years ago

  • Parent task set to #7356
Actions #5

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.0.12 and 3.1.5 which were released today.

Actions

Also available in: Atom PDF