Project

General

Profile

Bug #6758

rudder-webapp upgrade doesn't commit updates to ncf hooks

Added by Janos Mattyasovszky about 3 years ago. Updated 4 months ago.

Status:
Released
Priority:
3
Category:
Packaging
Target version:
Target version (plugin):
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Very Small
Priority:
51

Description

10.1.2. Upgrade -> Upgrading the Technique library

--> git add techniques/

This might not be sufficient, as the ncf hooks can also be updated:

#       modified:   ncf/ncf-hooks.d/post.write_technique.commit.sh
#       modified:   ncf/ncf-hooks.d/post.write_technique.rudderify.sh

Like a 2.11.6 -> 2.11.11 update:

rudder:/var/rudder/configuration-repository # git status
# On branch master
# Changes not staged for commit:
#   (use "git add/rm <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       deleted:    ncf/50_techniques/dfdf/dfdf.cf
#       modified:   ncf/ncf-hooks.d/post.write_technique.commit.sh
#       modified:   ncf/ncf-hooks.d/post.write_technique.rudderify.sh
#       modified:   techniques/applications/rpmPackageInstallation/6.1/rpmPackageInstallation.st
#       modified:   techniques/applications/rpmPackageInstallation/7.0/rpmPackageInstallation.st
#       modified:   techniques/applications/zypperPackageManagerRepositories/1.0/zypper-repositories-management.st
#       modified:   techniques/applications/zypperPackageManagerSettings/1.0/zypperPackageManagerSettings.st
#       modified:   techniques/applications/zypperPackageManagerSettings/2.0/zypperPackageManagerSettings.st
#       modified:   techniques/fileConfiguration/fileManagement/2.1/manageFilesAndFolders.st
#       modified:   techniques/fileConfiguration/fileManagement/3.0/manageFilesAndFolders.st
#       modified:   techniques/fileDistribution/checkGenericFileContent/5.0/checkGenericFileContent.st
#       modified:   techniques/fileDistribution/checkGenericFileContent/5.0/metadata.xml
#       modified:   techniques/fileDistribution/checkGenericFileContent/6.0/checkGenericFileContent.st
#       modified:   techniques/fileDistribution/checkGenericFileContent/6.0/metadata.xml
#       modified:   techniques/systemSettings/misc/clockConfiguration/1.0/clockConfiguration.st
#       modified:   techniques/systemSettings/misc/clockConfiguration/2.0/clockConfiguration.st
#       modified:   techniques/systemSettings/misc/genericVariableDefinition/1.0/metadata.xml
#       modified:   techniques/systemSettings/misc/genericVariableDefinition/1.1/metadata.xml
#       modified:   techniques/systemSettings/misc/genericVariableDefinition/1.2/metadata.xml
#       modified:   techniques/systemSettings/remoteAccess/sshConfiguration/3.0/config.st
#       modified:   techniques/systemSettings/remoteAccess/sshConfiguration/4.0/config.st

Would it be good to notice this, or is it sufficient to leave the git status command there and leave the admin to do the extra thinking of also including the hooks?

It will work since the files are there and will be used even without commiting it to git...


Subtasks

Bug #12116: Wrong path to ncf-hooks, debian postinst is using specfile variableReleasedVincent MEMBRÉ

Associated revisions

Revision 0463cc4a (diff)
Added by Benoît PECCATTE 4 months ago

Fixes #6758: rudder-webapp upgrade doesn't commit updates to ncf hooks

History

#1 Updated by Vincent MEMBRÉ almost 3 years ago

  • Project changed from Project website to Rudder
  • Category changed from rudder-project.org to Packaging
  • Priority changed from N/A to 3
  • Target version set to 2.11.12

In fact those files does not need to be commited, but since they are in the git we should commit them.

The commit should be done when upgrading the rudder-webapp package (the hooks are in that package)

Thank you for reporting this Janos!

#2 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.12 to 2.11.13

#3 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.13 to 2.11.14

#4 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.14 to 2.11.15

#5 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.15 to 2.11.16

#6 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.16 to 2.11.17

#7 Updated by Jonathan CLARKE over 2 years ago

  • Category changed from Packaging to Documentation

#8 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.17 to 2.11.18

#9 Updated by Jonathan CLARKE over 2 years ago

  • Subject changed from Documentation issue with Technique update to rudder-webapp doesn't commit updates to ncf hooks on upgrade
  • Category changed from Documentation to Packaging

We should indeed fix this so that the rudder-webapp package (that installs and updates these hooks) commits them in git if they got changed, to avoid users wondering about this. Or simply ignore them in git?

#10 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.18 to 2.11.19

#11 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.19 to 2.11.20

#12 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.20 to 2.11.21

#13 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.21 to 2.11.22

#14 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.22 to 2.11.23

#15 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 2.11.23 to 2.11.24

#16 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 2.11.24 to 308

#17 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 308 to 3.1.14

#18 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.14 to 3.1.15

#19 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.15 to 3.1.16

#20 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.16 to 3.1.17

#21 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.17 to 3.1.18

#22 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.18 to 3.1.19

#23 Updated by Jonathan CLARKE about 1 year ago

  • Subject changed from rudder-webapp doesn't commit updates to ncf hooks on upgrade to rudder-webapp upgrade doesn't commit updates to ncf hooks
  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
  • Priority set to 14

#24 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.19 to 3.1.20

#25 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.20 to 3.1.21

#26 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.21 to 3.1.22

#27 Updated by Benoît PECCATTE 12 months ago

  • Priority changed from 14 to 27

#28 Updated by Benoît PECCATTE 12 months ago

  • Effort required set to Very Small
  • Priority changed from 27 to 41

#29 Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 3.1.22 to 3.1.23

#30 Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 3.1.23 to 3.1.24

#31 Updated by Vincent MEMBRÉ 8 months ago

  • Target version changed from 3.1.24 to 3.1.25

#32 Updated by Benoît PECCATTE 7 months ago

  • Priority changed from 41 to 51

#33 Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 3.1.25 to 387

#34 Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 387 to 4.1.10

#35 Updated by Benoît PECCATTE 4 months ago

  • Status changed from New to In progress
  • Assignee set to Benoît PECCATTE

#36 Updated by Benoît PECCATTE 4 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Alexis MOUSSET
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1501

#37 Updated by Normation Quality Assistant 4 months ago

  • Assignee changed from Alexis MOUSSET to Benoît PECCATTE

#38 Updated by Benoît PECCATTE 4 months ago

  • Status changed from Pending technical review to Pending release

#39 Updated by Vincent MEMBRÉ 4 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.10 and 4.2.4 which were released today.

Also available in: Atom PDF