Project

General

Profile

Actions

Bug #6614

closed

User story #6553: Allow rudder server to remotely run the agent

cf-serverd.cf is broken because of missing promise type

Added by Alexis Mousset almost 9 years ago. Updated almost 9 years ago.

Status:
Released
Priority:
1
Assignee:
Matthieu CERDA
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When generating promises on 2.11.11 :

⇨ cf-promise check fails for promises generated at '/var/rudder/share/e19c5e00-4eda-4e97-a58c-07d4c3b30bca.new/rules/cfengine-community'
⇨ /var/rudder/share/e19c5e00-4eda-4e97-a58c-07d4c3b30bca.new/rules/cfengine-community/common/1.0/cf-served.cf:27:9: error: syntax error
⇨ any::
⇨ ^
⇨ /var/rudder/share/e19c5e00-4eda-4e97-a58c-07d4c3b30bca.new/rules/cfengine-community/common/1.0/cf-served.cf:27:9: error: Expected promise type, got 'any::'
⇨ any::
⇨ ^
[...]
⇨ Too many errors

The generated file contains :

bundle server access_rules
{
    any::
      # Allow server to remotely run the agent
      "/var/rudder/cfengine-community/bin/cf-agent" 
        admit   => { host2ip("${server_info.cfserved}"), string_downcase(escape("${server_info.cfserved}")) };

  roles:
      # Allow user root to set any class
      ".*"  authorize => { "root" };
}

which lacks the "access" promise type. This appears to be caused by https://github.com/Normation/rudder-techniques/pull/664, the promise type "access" should be moved before &if(CLIENTSLIST)&.


Subtasks 1 (0 open1 closed)

Bug #6624: Merge error in common technique, resulting in invalid codeReleasedBenoît PECCATTE2015-05-21Actions
Actions #1

Updated by Alexis Mousset almost 9 years ago

  • Target version changed from 2.11.11 to 2.10.14
Actions #2

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.10.14 to 2.10.15
Actions #3

Updated by Nicolas CHARLES almost 9 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Alexis Mousset
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/671
Actions #4

Updated by Nicolas CHARLES almost 9 years ago

  • Assignee changed from Alexis Mousset to Benoît PECCATTE

Benoit, could you have a look at the pr ?

Actions #5

Updated by Nicolas CHARLES almost 9 years ago

it also prevent dns lookup when variable is not set !

Actions #6

Updated by Benoît PECCATTE almost 9 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Benoît PECCATTE to Nicolas CHARLES
Actions #7

Updated by Benoît PECCATTE almost 9 years ago

  • Status changed from Discussion to In progress
  • Assignee changed from Nicolas CHARLES to Benoît PECCATTE
Actions #8

Updated by Benoît PECCATTE almost 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Matthieu CERDA
  • Pull Request changed from https://github.com/Normation/rudder-techniques/pull/671 to https://github.com/Normation/rudder-techniques/pull/673
Actions #9

Updated by Benoît PECCATTE almost 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #10

Updated by Matthieu CERDA almost 9 years ago

Actions #11

Updated by Nicolas CHARLES almost 9 years ago

  • Related to Bug #6624: Merge error in common technique, resulting in invalid code added
Actions #12

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.10.15 to 2.10.14
Actions #13

Updated by Vincent MEMBRÉ almost 9 years ago

  • Related to deleted (Bug #6624: Merge error in common technique, resulting in invalid code)
Actions #14

Updated by Vincent MEMBRÉ almost 9 years ago

  • Parent task changed from #6543 to #6553
Actions #15

Updated by Vincent MEMBRÉ almost 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.14, 2.11.11 and 3.0.5 which were released today.

Actions

Also available in: Atom PDF