Project

General

Profile

Actions
Copy link

Bug #6519

closed

When we add a node in a rule, we lose all compliance info on this rule applied on it, and we change promises of all the nodes of the rule

Added by Nicolas CHARLES almost 9 years ago. Updated almost 9 years ago.

Status:
Released
Priority:
1
Assignee:
François ARMAND
Category:
Web - Compliance & node report
Target version:
2.11.11
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

If I have Rule A applied on node 1, 2 and 3, and we add node4 in the target of the rule, the global compliance will be "Applying", even if nothing changed for RuleA on node1, 2 and 3
This is because we are eagerly increasing serial (think of version) of the rule when adding node (note that when we remove a node, the serial does not change)

It would be so much cooler to have the compliance for node1, 2 and 3 displayed, and Applying for node 4, as it would make compliance usable even when we change a lot the nodes
don't you think ?

Files

rules.png (32 KB) rules.png Nicolas CHARLES, 2015-04-19 22:56

Subtasks 2 (0 open — 2 closed)

Bug #6619: When only adding directives to Rules, reporting is not displayed for added directivesReleasedNicolas CHARLES2015-05-25Actions
Bug #6667: Adapt tests after new cache managementReleasedNicolas CHARLES2015-05-25Actions

Related issues 2 (0 open — 2 closed)

Related to Rudder - Bug #6723: When we add a node, we have some rules where we loose all complianceRejectedActions
Related to Rudder - Bug #7080: Clear cache doesn't regenerate expected reportsReleasedFrançois ARMAND2015-08-06Actions
Actions
Copy link
 #1

Updated by Nicolas CHARLES almost 9 years ago

With the change, here is what we get

Actions
Copy link
 #2

Updated by Nicolas CHARLES almost 9 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/850

https://github.com/Normation/rudder/pull/850

We need to check that it doesn't break the advanced report plugin also

But this 8 lines change changes everything, and even if it is a behavioural change, I'm conviced it need to be merged in 2.11 (fix in 2.10 would be much larger and difficult)

Actions
Copy link
 #3

Updated by Nicolas CHARLES almost 9 years ago

checked the advanced report plugin, it seems to be compliant

Actions
Copy link
 #4

Updated by Nicolas CHARLES almost 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Nicolas CHARLES almost 9 years ago

  • Related to Bug #6619: When only adding directives to Rules, reporting is not displayed for added directives added
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ almost 9 years ago

  • Related to deleted (Bug #6619: When only adding directives to Rules, reporting is not displayed for added directives)
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ almost 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.11 and 3.0.5 which were released today.

Actions
Copy link
 #8

Updated by Nicolas CHARLES almost 9 years ago

  • Related to Bug #6723: When we add a node, we have some rules where we loose all compliance added
Actions
Copy link
 #9

Updated by Nicolas CHARLES over 8 years ago

  • Related to Bug #7080: Clear cache doesn't regenerate expected reports added
Actions
Copy link

Also available in: Atom PDF