Project

General

Profile

Bug #6343

When a technique reports several time the exact same text, there is only one report generated

Added by Nicolas CHARLES over 3 years ago. Updated 2 months ago.

Status:
Released
Priority:
N/A
Category:
System techniques
Target version:
Target version (plugin):
Severity:
Major - prevents use of part of Rudder | no simple workaround
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Priority:
60

Description

In the Technique refactoring in Rudder 3.0 to use rudder_common_reports, we introduced a bug which prevent to have duplicate identical reports.

The main problem is that we are calling a bundle to do reports, with exactly the same parameters, and in this bundle, the agent detects that he already handled this promises, and skip it !

This bug appears when in a given directive, we are managing twice (or more) the same object.

A workaround would be to create a new version of rudder_common_report and rudder_common_report_generic, with a new parameter (the current index), and se this index as an handle or comment of the usebundle and reports.
This permit the agent to distinguish each promises.

This should go at least in 3.0, but could go to 2.11 to allow backporting of techniques


Subtasks

Bug #6311: Missing reports when editing twice the same file with enforce a file content v7.0ReleasedNicolas CHARLES
Bug #6465: Update rudder_common_report and rudder_common_reports_generic to be compatible wiht multi instance techniqueReleasedBenoît PECCATTE
Bug #6469: Typo in rudder_common_reports_genericReleasedBenoît PECCATTE
Bug #12882: same as parent ticket for branch 4.3ReleasedAlexis MOUSSET
Bug #12941: typo introduced by parent ticket -branch 4.3)ReleasedAlexis MOUSSET
Bug #12889: spurious rudder_common_report_indexs_generic_index introduced by parent ticketReleasedAlexis MOUSSET
Bug #12917: typo introduced by parent ticketReleasedAlexis MOUSSET

Associated revisions

Revision 48cf123c (diff)
Added by Nicolas CHARLES 3 months ago

Fixes #6343: When a technique reports several time the exact same text, there is only one report generated

History

#1 Updated by Nicolas CHARLES over 3 years ago

  • Status changed from New to Discussion

#2 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.8 to 2.11.9

#3 Updated by Benoît PECCATTE over 3 years ago

We should change Rudder internal API in the following way:

- add a new report bundle that take a new parameter, named or call_id or ...
- call this bundle instead of rudder_common_report in every technique that is multi-instance or can have multivalued components
- use the existing index for multivaluation in the technique as the new parameter
- On old Rudder versions the new bundle should create a report with message containing the index (as nicely as possible)
- On new Rudder versions the new bundle should create a report with a new field containing the index that is parsable by Rudder

#4 Updated by Benoît PECCATTE over 3 years ago

  • Status changed from Discussion to 8
  • Assignee deleted (Benoît PECCATTE)

#5 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.9 to 2.11.10

#6 Updated by Nicolas CHARLES over 3 years ago

I checked, and this fix should go in 2.10 as well, there are multininstance technique there using rudder_common_report

#7 Updated by Benoît PECCATTE over 3 years ago

  • Status changed from 8 to New

#8 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.10 to 2.11.11

#9 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.11 to 2.11.12

#10 Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 2.11.12 to 2.11.13

#11 Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 2.11.13 to 2.11.14

#12 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.14 to 2.11.15

#13 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.15 to 2.11.16

#14 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.16 to 2.11.17

#15 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.17 to 2.11.18

#16 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.18 to 2.11.19

#17 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.19 to 2.11.20

#18 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.20 to 2.11.21

#19 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.21 to 2.11.22

#20 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.22 to 2.11.23

#21 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.23 to 2.11.24

#22 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.24 to 308

#23 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 308 to 3.1.14

#24 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.14 to 3.1.15

#25 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.15 to 3.1.16

#26 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.16 to 3.1.17

#27 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.17 to 3.1.18

#28 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.18 to 3.1.19

#29 Updated by Jonathan CLARKE over 1 year ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Getting started - demo | first install | level 1 Techniques

#30 Updated by Benoît PECCATTE over 1 year ago

  • Priority set to 45

#31 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.19 to 3.1.20

#32 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.20 to 3.1.21

#33 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.21 to 3.1.22

#34 Updated by Benoît PECCATTE about 1 year ago

  • Priority changed from 45 to 58

#35 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.22 to 3.1.23

#36 Updated by Alexis MOUSSET about 1 year ago

  • Subject changed from When a Rudder 3.0 Technique reports several time the same the same text, there is only one report generated to When a technique reports several time the exact same text, there is only one report generated

#37 Updated by Alexis MOUSSET about 1 year ago

rudder_common_report_index allows avoiding this issue. I'm not closing this issue as it is likely not used everywhere.

#38 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.23 to 3.1.24

#39 Updated by Vincent MEMBRÉ 11 months ago

  • Target version changed from 3.1.24 to 3.1.25

#40 Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 3.1.25 to 387

#41 Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 387 to 4.1.10

#42 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 4.1.10 to 4.1.11

#43 Updated by Vincent MEMBRÉ 5 months ago

  • Target version changed from 4.1.11 to 4.1.12
  • Priority changed from 58 to 59

#44 Updated by Vincent MEMBRÉ 4 months ago

  • Target version changed from 4.1.12 to 4.1.13

#45 Updated by Vincent MEMBRÉ 3 months ago

  • Assignee set to Nicolas CHARLES
  • Priority changed from 59 to 60

#46 Updated by Nicolas CHARLES 3 months ago

  • Status changed from New to In progress

#47 Updated by Nicolas CHARLES 3 months ago

i'm using this expression to replace

sed -i "s/\(.*\)rudder_common_report\(.*\)\"),/\1rudder_common_report_index\2\", \"\${index}\"),/" 

#48 Updated by Nicolas CHARLES 3 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Alexis MOUSSET
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1321

#49 Updated by Normation Quality Assistant 3 months ago

  • Assignee changed from Alexis MOUSSET to Nicolas CHARLES

#50 Updated by Nicolas CHARLES 3 months ago

  • Status changed from Pending technical review to Pending release

#51 Updated by Vincent MEMBRÉ 2 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.13, 4.2.7 and 4.3.3 which were released today.

Also available in: Atom PDF