Project

General

Profile

Bug #5942

Comas in the full name field make the users technique fail

Added by Alexander Brunhirl over 3 years ago. Updated about 1 month ago.

Status:
New
Priority:
N/A
Assignee:
-
Category:
Techniques
Target version:
Target version (plugin):
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Small
Priority:
58

Description

Hi,

if there's a comma in the GECOS field, the rule is not be actually applied.

Example Output:
Status Success "The user testuser1 ( test user 1 111 49089-XYZ 00_1 ) is already present on the system"
Status Repaired "The user testuser2 ( test user 2, 111, 49089-XYZ, 00_2 ) had a wrong fullname"

Directive: User management
Directive version: 5.0
Rudder version: Rudder v.2.11.5~rc1~git201411220241


Related issues

Related to Rudder - Bug #5327: On 2.11 rudder-agent, "Repair" status is always defined, even if nothing is modifiedReleased2014-07-30

History

#1 Updated by Nicolas CHARLES over 3 years ago

Hi alex,

Thank you for your bug report, I'll investigate the issue

#3 Updated by Nicolas CHARLES over 3 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/602/files

#4 Updated by Jonathan CLARKE over 3 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to Alexander Brunhirl

Hi Alex!

Actually, I think that what you're trying to do here is unsupported. The GECOS field in /etc/passwd should contain the following fields: Full name,Room number,Work phone,Home Phone,Other. The comma is the separator here.

By using commas in the "Full name" field in Rudder's Technique, you're effectively trying to use the "Full name" field as "GECOS" field. This is not supported, the point of this field is to fill in the "Full name".

However, there is indeed a bug here: we should filter out commas to avoid "breaking" the GECOS field, and make sure the Technique only changes the first field.

We could, of course, add a new Technique version to also manage the others fields from GECOS. Would this be useful to you?

#5 Updated by Alexander Brunhirl over 3 years ago

Hi Jonathan,

thanks for the explaining :-)
I thought with the "Full name" field you meant the entire GECOS field, so I tried this.

It isn't necessary for me, but maybe it's quite useful for others to add this feature.

#6 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.5 to 2.11.6

#7 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.6 to 2.11.7

#8 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.7 to 2.11.8

#9 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.8 to 2.11.9

#10 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.9 to 2.11.10

#11 Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 2.11.10 to 2.11.11

#12 Updated by Benoît PECCATTE about 3 years ago

  • Assignee deleted (Alexander Brunhirl)

#13 Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 2.11.11 to 2.11.12

#14 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.12 to 2.11.13

#15 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.13 to 2.11.14

#16 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.14 to 2.11.15

#17 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.15 to 2.11.16

#18 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.16 to 2.11.17

#19 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.17 to 2.11.18

#20 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.18 to 2.11.19

#21 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.19 to 2.11.20

#22 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.20 to 2.11.21

#23 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.21 to 2.11.22

#24 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.22 to 2.11.23

#25 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 2.11.23 to 2.11.24

#26 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 2.11.24 to 308

#27 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 308 to 3.1.14

#28 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.14 to 3.1.15

#29 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.15 to 3.1.16

#30 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.16 to 3.1.17

#31 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.17 to 3.1.18

#32 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.18 to 3.1.19

#33 Updated by Jonathan CLARKE over 1 year ago

  • Status changed from Discussion to New
  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Getting started - demo | first install | level 1 Techniques

#34 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.19 to 3.1.20
  • Priority set to 0

#35 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.20 to 3.1.21

#36 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.21 to 3.1.22

#37 Updated by Benoît PECCATTE 12 months ago

  • Subject changed from GECOS field to Comas in the full name fiemld make the users technique fail
  • Priority changed from 0 to 29

We should not accept comas here.

#38 Updated by Benoît PECCATTE 12 months ago

  • Priority changed from 29 to 42

#39 Updated by Benoît PECCATTE 12 months ago

  • Effort required set to Small
  • Priority changed from 42 to 45

#40 Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 3.1.22 to 3.1.23

#41 Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 3.1.23 to 3.1.24

#42 Updated by Vincent MEMBRÉ 8 months ago

  • Target version changed from 3.1.24 to 3.1.25

#43 Updated by Benoît PECCATTE 7 months ago

  • Priority changed from 45 to 55

#44 Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 3.1.25 to 387

#45 Updated by Alexis MOUSSET 6 months ago

  • Subject changed from Comas in the full name fiemld make the users technique fail to Comas in the full name field make the users technique fail

#46 Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 387 to 4.1.10

#47 Updated by Vincent MEMBRÉ 4 months ago

  • Target version changed from 4.1.10 to 4.1.11
  • Priority changed from 55 to 56

#48 Updated by Vincent MEMBRÉ 2 months ago

  • Target version changed from 4.1.11 to 4.1.12
  • Priority changed from 56 to 57

#49 Updated by Vincent MEMBRÉ about 1 month ago

  • Target version changed from 4.1.12 to 4.1.13
  • Priority changed from 57 to 58

Also available in: Atom PDF