Project

General

Profile

Actions

Bug #5528

closed

Get system serial number output from inventory though API

Added by Olivier Mauras over 9 years ago. Updated over 9 years ago.

Status:
Released
Priority:
3
Category:
API
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Hello,

It seems that even fetching full inventory doesn't output the system serial number.
Could you please add a way to get it?

Thanks,
Olivier

Edit, FAR: for reference, both the "serial" and "manufacturer" fields viewable in the node inventory details, in the [General] section since Rudder 2.11 are concerned.

Actions #1

Updated by Matthieu CERDA over 9 years ago

  • Status changed from New to 8
  • Assignee set to François ARMAND
  • Priority changed from N/A to 3

Giving this to FAR, he knows what's what about this :)

Actions #2

Updated by François ARMAND over 9 years ago

  • Description updated (diff)
  • Target version set to 2.11.3
Actions #3

Updated by François ARMAND over 9 years ago

  • Tracker changed from User story to Bug

This seems to be a bug, because we added these information in 2.11 in the main panel but not in the API.

Actions #4

Updated by François ARMAND over 9 years ago

  • Pull Request set to https://github.com/Normation/rudder/pull/613

Proposed place for these information:

- 1/ in the main (first) level:

"data": {
"nodes": [ {
"id": "32e45242-5571-4d9b-87ae-07b02b6f8fff",
"hostname": "node1.rudder.local",
....
"manufacturer": "innotek GmbH",
"systemSerialNumber": "0",
....
"os": {
....
}
... other caracteristics ...
}
}

2/ in the "machine"

"data": {
"nodes": [ {
"id": "32e45242-5571-4d9b-87ae-07b02b6f8fff",
"hostname": "node1.rudder.local",
....
....
"os": {
....
}
"machine": {
"id": "883EC5E5-5614-4F4F-881C-AE2AF8952DF4",
"type": "Virtual",
"provider": "vbox",
"manufacturer": "innotek GmbH",
"serialNumber": "0"
},
... other caracteristics ...
}
}

1/ map the most closely the logic of the node details. But 2/ seems more logical: these fields are optionnal and are actual caracteristic of the hardware.

For the naming scheme, I think "manufacturer" is OK. For the "system serial number", I think the whole name is needed if at the root level (case 1), but "machine.serialNumber" is shorter/better.

So I would go for 2, and the PR available here allow to test that solution: https://github.com/Normation/rudder/pull/613

Actions #5

Updated by François ARMAND over 9 years ago

  • Status changed from 8 to Discussion
  • Assignee changed from François ARMAND to Jonathan CLARKE

(Jon feedback as keeper of the ux :)

Actions #6

Updated by Olivier Mauras over 9 years ago

Hello François,

I agree with the second solution.

Olivier

Actions #7

Updated by François ARMAND over 9 years ago

  • Status changed from Discussion to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

I just got an offline "go" feedback for the solution 2/ from Jon.

Actions #8

Updated by François ARMAND over 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #10

Updated by Vincent MEMBRÉ over 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.3, which was released on the 25/09/2014.

Actions

Also available in: Atom PDF