Project

General

Profile

Actions
Copy link

Bug #5489

closed

Purge old {run,}logs

Added by Lionel Le Folgoc over 9 years ago. Updated over 9 years ago.

Status:
Rejected
Priority:
5
Assignee:
Matthieu CERDA
Category:
System integration
Target version:
Ideas (not version specific)
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Hi,

When a player is renamed, old {run,}logs are not purged, so in /var/rudder/cfengine-community/, cf3.$myhost.{run,}log accumulate. Any chance they could be cleared when the hsotname part doesn't match?

Thanks.

Actions
Copy link
 #1

Updated by Matthieu CERDA over 9 years ago

  • Category set to System integration
  • Status changed from New to Discussion
  • Assignee set to Lionel Le Folgoc
  • Priority changed from N/A to 5
  • Target version set to Ideas (not version specific)

Hmmmm, this would logically map to:

for every log and runlog
  if (hostname part of logs) != (current hostname)
  then delete log
  end if
end for

I agree this can be a problem, but:
  • Node renaming is not really a common operation :)
  • Old logs are kept just in case you want to keep them as a debugging / history reference and possibly backup them
I feel that automatically assuming those files are not relevant anymore and purging them is dangerous for two reasons:
  • We decide something in the name of the user, thant might not want it
  • We delete something, which is not a trivial operation and might cause serious problem if something breaks

I do think this would better be part of the renaming procedure than an automatic operation, but I'm open to arguments of course :)

What do you think ?

Actions
Copy link
 #2

Updated by Lionel Le Folgoc over 9 years ago

Ok, we're probably the only ones who have to support renaming players as a normal operation. :P
Is there any setting in cfengine to not write this log?
(right now we're going for a cron job to delete *.runlog, because it's growing too fast for a 1G-/var)

Actions
Copy link
 #3

Updated by Nicolas CHARLES over 9 years ago

Actually, if i'm correct, these logs are redundant with what lies in /var/rudder/cfengine_community/outputs
Shouldn't we simply purge or rotate the runlogs, as they grows too big ?

Actions
Copy link
 #4

Updated by François ARMAND over 9 years ago

We looked at that more preciselly, and these log are completly unuseful as they are redondunt with other output.
So, their only use could be for debugging, and even that...

So, we are going to just remove the writting in these files (in #5488), and so that bug become irrelevant and I propose to close it as "rejected". Does that seems OK ?

Actions
Copy link
 #5

Updated by Lionel Le Folgoc over 9 years ago

That's fine, thanks.

Actions
Copy link
 #6

Updated by Matthieu CERDA over 9 years ago

  • Status changed from Discussion to Rejected
  • Assignee changed from Lionel Le Folgoc to Matthieu CERDA
  • % Done changed from 0 to 100

As asked by FAR and Lionel, rejecting this ticket. See you soon on #5488 !

Actions
Copy link

Also available in: Atom PDF