Project

General

Profile

Bug #5432

Deleted Technique from NCF builder are still present in Rudder Technique library

Added by John Robert Mendoza almost 4 years ago. Updated about 1 month ago.

Status:
New
Priority:
3
Assignee:
-
Category:
Web - Technique editor
Target version:
Target version (plugin):
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Small
Pull Request:
Priority:
59

Description

The reference technique library page doesn't get updated and still shows the custom technique I've deleted from ncf editor. Here's how to reproduce the bug.

1. Create a new technique using the ncf technique editor
2. Check the technique library management page and the newly created technique will be shown under the "Meta Technique" section of the Reference Technique Library tree.
3. Head back to the technique editor and delete your custom technique.
4. Refresh the library management page. Observe that the custom technique is still displayed.


Related issues

Has duplicate Rudder - Bug #5829: Deleted Technique from NCF builder are still present in Rudder Technique libraryRejected

History

#1 Updated by John Robert Mendoza almost 4 years ago

Forgot to mention the target version for this. It's 2.11.2-release-1

#2 Updated by Vincent MEMBRÉ almost 4 years ago

  • Assignee set to Vincent MEMBRÉ
  • Target version set to 2.11.3

Thank you for reporting John.

In fact the technique is not automatically deleted from Rudder. I will add a way to automate this.

for now, you can manually delete the technique:

cd /var/rudder/configuration-repository
# A 'git status' would show that cfengine files were deleted, but it was not commited, so rm the files
git rm -r ncf/50_techniques/my_technique techniques/ncf_techniques/my_technique
git commit -m "delete my_technique" 
# Reload technique library
curl -s -f -k "https://localhost/rudder/api/techniqueLibrary/reload" 

I will add ncf-hooks that delete the files automatically. and reload Rudder technique library

#3 Updated by Vincent MEMBRÉ almost 4 years ago

Before running those commands, please delete all Directive that were created based on that Technique

#4 Updated by Matthieu CERDA over 3 years ago

  • Target version changed from 2.11.3 to 2.11.4

#5 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.4 to 2.11.5

#6 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.5 to 2.11.6

#7 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.6 to 2.11.7

#8 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.7 to 2.11.8

#9 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.8 to 2.11.9

#10 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.11.9 to 2.11.10

#11 Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 2.11.10 to 2.11.11

#12 Updated by Benoît PECCATTE about 3 years ago

  • Category set to Web - Technique editor

#13 Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 2.11.11 to 2.11.12

#14 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.12 to 2.11.13

#15 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.13 to 2.11.14

#16 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.11.14 to 2.11.15

#17 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.15 to 2.11.16

#18 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.16 to 2.11.17

#19 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.17 to 2.11.18

#20 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.18 to 2.11.19

#21 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.19 to 2.11.20

#22 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.20 to 2.11.21

#23 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.21 to 2.11.22

#24 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.22 to 2.11.23

#25 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 2.11.23 to 2.11.24

#26 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 2.11.24 to 308

#27 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 308 to 3.1.14

#28 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.14 to 3.1.15

#29 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.15 to 3.1.16

#30 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.16 to 3.1.17

#31 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.17 to 3.1.18

#32 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.18 to 3.1.19

#33 Updated by François ARMAND about 1 year ago

  • User visibility set to Getting started - demo | first install | level 1 Techniques
  • Effort required set to Small
  • Priority set to 0

This is still happening.
When a directive created from the deleted technique is configured on a node, running "rudder agent run" leads to:

Rudder agent 3.1.19.rc1.git201704040733 (CFEngine Core 3.6.5)
Node uuid: root
2017-04-04T12:04:20+0200    error: Bundle 'vim_install' listed in the bundlesequence is not a defined bundle
2017-04-04T12:04:20+0200    error: Fatal CFEngine error: Errors in promise bundles: could not verify bundlesequence
error    Rudder agent was interrupted during execution by a fatal error
         Run with -i to see log messages.

## Summary #####################################################################
error:        1
execution time: 0.65s
################################################################################

But nothing in the UI let you thing that there a problem (no error in generation, after delete, etc). And you can even create again new directive from the deleted technique, without any error!
Moreover, the compliance is only in "no answer", so we need to go the node to understand the problem.

You have to delete all directives from that technique by hand to make rudder agent works again.

#34 Updated by François ARMAND about 1 year ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround

I'm setting the severity to major, because of the potential silent breaking of all nodes with the directive, and a not so easy diagnosis for the problem.

#35 Updated by François ARMAND about 1 year ago

  • Has duplicate Bug #5829: Deleted Technique from NCF builder are still present in Rudder Technique library added

#36 Updated by François ARMAND about 1 year ago

  • Subject changed from Reference Technique Library Tree after deleting custom NCF directive to Deleted Technique from NCF builder are still present in Rudder Technique library

#37 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.19 to 3.1.20

#38 Updated by Jonathan CLARKE about 1 year ago

  • Assignee deleted (Vincent MEMBRÉ)

#39 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.20 to 3.1.21

#40 Updated by François ARMAND about 1 year ago

  • Severity changed from Major - prevents use of part of Rudder | no simple workaround to Minor - inconvenience | misleading | easy workaround
  • Priority changed from 0 to 36

This must be tested again. In 4.1, it seems that the directive is disabled (or at least not accessible in the UI) when the ncf technique is deleted, and so the policy generation is not broken. (and so, Minor in place of major).

In all cases, we must add some warning regarding the usage of the technique before deleting it.

#41 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.21 to 3.1.22

#42 Updated by Benoît PECCATTE 12 months ago

  • Priority changed from 36 to 45

#43 Updated by Vincent MEMBRÉ 11 months ago

  • Target version changed from 3.1.22 to 3.1.23

#44 Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 3.1.23 to 3.1.24

#45 Updated by Vincent MEMBRÉ 8 months ago

  • Target version changed from 3.1.24 to 3.1.25
  • Priority changed from 45 to 46

#46 Updated by Benoît PECCATTE 8 months ago

  • Priority changed from 46 to 56

#47 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 3.1.25 to 387
  • Priority changed from 56 to 57

#48 Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 387 to 4.1.10

#49 Updated by Vincent MEMBRÉ 4 months ago

  • Target version changed from 4.1.10 to 4.1.11
  • Priority changed from 57 to 58

#50 Updated by Vincent MEMBRÉ 2 months ago

  • Target version changed from 4.1.11 to 4.1.12
  • Priority changed from 58 to 59

#51 Updated by Vincent MEMBRÉ about 1 month ago

  • Target version changed from 4.1.12 to 4.1.13

Also available in: Atom PDF