Project

General

Profile

Bug #4895

Wrong error message when accepted an already accepted node

Added by Matthieu CERDA over 4 years ago. Updated over 3 years ago.

Status:
Released
Priority:
3
Category:
Web - Nodes & inventories
Target version:
Target version (plugin):
Severity:
User visibility:
Effort required:
Priority:

Description

When I try to accept a new node that for some reason already exists (on a Rudder 2.6.10 server):

Error when trying to execute pre-accepting for phase accept_new_server:check_hostname_unicity. Stop. <- There is already a node with Hostname 'centos-6-64.labo.normation.com' in database. You can not add it again. 

Maybe we should display something less frightening like "There is already a node with Hostname 'centos-6-64.labo.normation.com' in database. You can not add it again." and leave "Error when trying to execute pre-accepting for phase accept_new_server:check_hostname_unicity. Stop." for the log debug output :)

Associated revisions

Revision 1c21fc0b (diff)
Added by François ARMAND over 3 years ago

Fixes #4895: The error thant appears while a node to be accepted already exists is frightening

Revision dcae7319 (diff)
Added by François ARMAND over 3 years ago

Fixes #4895: The error thant appears while a node to be accepted already exists is frightening

Revision 9ee1ddc0
Added by Vincent MEMBRÉ over 3 years ago

Merge pull request #815 from fanf/bug_4895/the_error_thant_appears_while_a_node_to_be_accepted_already_exists_is_frightening

Fixes #4895: The error thant appears while a node to be accepted already...

Revision 61dc3469
Added by Vincent MEMBRÉ over 3 years ago

Merge pull request #815 from fanf/bug_4895/the_error_thant_appears_while_a_node_to_be_accepted_already_exists_is_frightening

Fixes #4895: The error thant appears while a node to be accepted already...

History

#1 Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.6.13 to 2.6.14

#2 Updated by Jonathan CLARKE over 4 years ago

  • Target version changed from 2.6.14 to 2.6.16

#3 Updated by Jonathan CLARKE about 4 years ago

  • Target version changed from 2.6.16 to 2.6.17

#4 Updated by Nicolas PERRON about 4 years ago

  • Target version changed from 2.6.17 to 2.6.18

#5 Updated by Matthieu CERDA almost 4 years ago

  • Target version changed from 2.6.18 to 2.6.19

#6 Updated by Vincent MEMBRÉ almost 4 years ago

  • Target version changed from 2.6.19 to 2.6.20

#7 Updated by François ARMAND over 3 years ago

  • Status changed from 8 to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Nicolas CHARLES
  • Target version changed from 2.6.20 to 2.10.10
  • Pull Request set to https://github.com/Normation/rudder/pull/815

Nico, if you mind review that one: https://github.com/Normation/rudder/pull/815

#8 Updated by François ARMAND over 3 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

#10 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.10.10 to 2.10.9

#11 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.10.9 to 2.10.10

#12 Updated by Vincent MEMBRÉ over 3 years ago

  • Subject changed from The error thant appears while a node to be accepted already exists is frightening to Wrong error message when accepted an already accepted node

#13 Updated by Vincent MEMBRÉ over 3 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.10 and 2.11.7, which were these days.

Also available in: Atom PDF