Project

General

Profile

Actions

Bug #4548

closed

Correct file opening/closing on cf-agent (backport of 3.5.3 code)

Added by Nicolas CHARLES about 10 years ago. Updated about 9 years ago.

Status:
Rejected
Priority:
1
Category:
Packaging
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The agent don't correctly handle files opening/closing, apparently causing problems stated in #4494

This ticket is to backport the modifications made on CFEngine 3.5.3 code to improve file management


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #4494: Accumulation of cf-agent processes due to locking on CFEngine tcdb lock fileReleasedJonathan CLARKEActions
Actions #1

Updated by Nicolas CHARLES about 10 years ago

  • Project changed from Rudder to 34
  • Category deleted (14)
Actions #2

Updated by Nicolas CHARLES about 10 years ago

See https://github.com/cfengine/core/pull/1116 plus others commits in the patch (no link to ticket on cfengine bugtracker, as it is on their internal bugtracker)

Actions #3

Updated by Nicolas CHARLES about 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/243
Actions #4

Updated by Nicolas CHARLES about 10 years ago

This has been tested against CFEngine unit test + ncf unit test

Actions #5

Updated by Nicolas CHARLES about 10 years ago

In CFEngine 3.5.3, lots of commits when introduced (some, without pull request) to fix the way files where handled.
This ticket is simply to take these commits from 3.5.3 to 3.5.2, the version we are using

They where chosen by looking at the logs on the 3.5.x branch, with comment containing safe_open

Actions #6

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.8.3 to 2.8.4
Actions #7

Updated by Jonathan CLARKE about 10 years ago

  • Status changed from Pending technical review to Rejected

This was replaced by #4553 - a full upgrade to CFEngine 3.5.3, instead of porting half the patches :)

Actions #8

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.8.4 to 2.8.3
Actions #9

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions

Also available in: Atom PDF