Project

General

Profile

Bug #4492

When accepting several nodes, one policy generation is triggered for each of them

Added by Vincent MEMBRÉ over 4 years ago. Updated over 4 years ago.

Status:
Released
Priority:
2
Category:
Web - Nodes & inventories
Target version:
Target version (plugin):
Severity:
User visibility:
Effort required:
Priority:

Description

WHen you accept more than one node, a deployment is launched for every node.

This is totally useless, and only one deployment should be launched once every node is accepted.

If a deployment succeed while nodes are accepted it will be not be complete (miss some nodes) and replaced right after.

Moreover, a deployment is started when nodes are refused, what make no sens, because no modification on the configuration of the infrastructure can happen on that case.

Associated revisions

Revision 18a4c604 (diff)
Added by François ARMAND over 4 years ago

Fixes #4492: generate policies only one time when accepting multiple nodes

Revision 73a1ef81 (diff)
Added by François ARMAND over 4 years ago

Fixes #4492: generate policies only one time when accepting multiple nodes

Revision 4fd42109
Added by Nicolas CHARLES over 4 years ago

Merge pull request #467 from fanf/bug_4492/deploy_only_one_time_when_accepting_nodes

Fixes #4492: generate policies only one time when accepting multiple nodes

Revision 21937f0f
Added by Nicolas CHARLES over 4 years ago

Merge pull request #467 from fanf/bug_4492/deploy_only_one_time_when_accepting_nodes

Fixes #4492: generate policies only one time when accepting multiple nodes

History

#1 Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.6.11 to 2.6.12

#2 Updated by François ARMAND over 4 years ago

I believe it is more than a bug for 2.6, so if it's more than 2 lines, it should bo to 2.10.

#3 Updated by François ARMAND over 4 years ago

In fact, the correction is trivial and also correct the fact that policies are regenerated when refusing nodes, so correcting it to 2.6.

#4 Updated by François ARMAND over 4 years ago

  • Status changed from New to In progress
  • Assignee changed from Vincent MEMBRÉ to François ARMAND

#5 Updated by François ARMAND over 4 years ago

  • Subject changed from When accepting several nodes, there is as many deployment launched to When accepting several nodes, one policy generation is triggered for each of them

#6 Updated by François ARMAND over 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/467

#7 Updated by François ARMAND over 4 years ago

  • Description updated (diff)

#8 Updated by Nicolas CHARLES over 4 years ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from Nicolas CHARLES to François ARMAND

Francois,

I guess you forgot a "if" condition, or either you defined unused variables

#9 Updated by François ARMAND over 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES

PR updated

#10 Updated by François ARMAND over 4 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

#12 Updated by Vincent MEMBRÉ over 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.6.12, which was released today.
Check out:

Also available in: Atom PDF