Project

General

Profile

Actions
Copy link

Bug #4278

closed

Technique "Download a file from the shared folder": Error message when a copy failed using does not explain what actually failed

Added by Nicolas PERRON over 10 years ago. Updated about 9 years ago.

Status:
Released
Priority:
1
Assignee:
Nicolas CHARLES
Category:
Techniques
Target version:
2.6.11
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

With the use of Download from a shared folder, when a copy is in error, the message returned is not clear. The only way to know a little about the error is to go on the server.
By experience, I know that errors could be made by:
- Wrong/no variable initialized if variable is used
- No file on the server side
- User/Group does not exist on the machine
- (Destination path is on a non existent folder) [not sure about it]

It could be great if the errors messages returned to the application could show us some of these distinctions

Actions
Copy link
 #1

Updated by Nicolas CHARLES over 10 years ago

  • Category set to Techniques
  • Status changed from New to 8
  • Assignee set to Matthieu CERDA
  • Priority changed from N/A to 1

Indeed, it would be great to have some more details.
Matthieu, can you work on this please ?

Actions
Copy link
 #2

Updated by Matthieu CERDA over 10 years ago

  • Status changed from 8 to In progress
Actions
Copy link
 #3

Updated by Matthieu CERDA over 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • Target version changed from 2.4.13 to 2.6.10
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/260

PR ready

Actions
Copy link
 #4

Updated by Jonathan CLARKE over 10 years ago

  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

Nico, could you take a look at this TR please? I've looked it over but I'm a bit unsure about some things, and am running short on time - I thought you would do a better job at this right now!

Actions
Copy link
 #5

Updated by Nicolas CHARLES over 10 years ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from Nicolas CHARLES to Matthieu CERDA

Matthieu, I made some minor remark, could you remove the 

copy_file_${index}_src_unexpanded" and "copy_file_${index}_dest_unexpanded

and everything that depends on it, or explain clearly the intention that I may have missed

Actions
Copy link
 #6

Updated by Vincent MEMBRÉ over 10 years ago

  • Target version changed from 2.6.10 to 2.6.11
Actions
Copy link
 #7

Updated by Matthieu CERDA about 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE

PR updated !

Actions
Copy link
 #8

Updated by Jonathan CLARKE about 10 years ago

  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

Nico was doing this TR, back over to him.

Actions
Copy link
 #9

Updated by Nicolas CHARLES about 10 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Nicolas CHARLES to Matthieu CERDA

Matthieu,

I've made some remarks/questions on your PR, could you answer them ?

Thank you !

Actions
Copy link
 #10

Updated by Matthieu CERDA about 10 years ago

  • Assignee changed from Matthieu CERDA to Nicolas CHARLES

Yup, the indentation has been corrected!

Actions
Copy link
 #11

Updated by Matthieu CERDA about 10 years ago

  • Status changed from Discussion to Pending release

Applied in changeset commit:7a5cdee4db5a1acdae121ce73b447a32a65c0a71.

Actions
Copy link
 #12

Updated by Nicolas CHARLES about 10 years ago

Applied in changeset commit:88212f7695667a1e1f5c6ceffa10a498bc56969d.

Actions
Copy link
 #13

Updated by Vincent MEMBRÉ about 10 years ago

  • Subject changed from Technique "Download from a shared folder": The error messages when a copy could not have been made shoule be more explicit to Error message when a copy failed using Technique "Download from a shared folder" does not explain what actually fialed
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ about 10 years ago

  • Subject changed from Error message when a copy failed using Technique "Download from a shared folder" does not explain what actually fialed to Error message when a copy failed using Technique "Download from a shared folder" does not explain what actually failed
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ about 10 years ago

  • Subject changed from Error message when a copy failed using Technique "Download from a shared folder" does not explain what actually failed to Technique "Download from a shared folder": Error message when a copy failed using does not explain what actually failed
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ about 10 years ago

  • Subject changed from Technique "Download from a shared folder": Error message when a copy failed using does not explain what actually failed to Technique "Download a file from the shared folder": Error message when a copy failed using does not explain what actually failed
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ about 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.6.11, which was released today.
Check out:

Actions
Copy link
 #18

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions
Copy link

Also available in: Atom PDF