Project

General

Profile

Actions

Bug #4206

closed

Incorrect English grammar in documentation

Added by Dennis Cabooter over 10 years ago. Updated about 10 years ago.

Status:
Released
Priority:
N/A
Category:
Web - UI & UX
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Some of the grammar within the Rudder web interface and the Rudder documentation isn't correct. I tried to locate the incorrect grammar in the code as well in the documentation.

Basicly the incorrect grammar comes down to:

- the word "informations" should be "information", since it's never plural
- It's "each component" or instead of "every components"
- It's "each element" instead of "each elements"
- It's "this information" instead of "these information", since these is used for the plural and "information" is always singular

https://github.com/Normation/rudder-doc/pull/37
https://github.com/Normation/rudder/pull/362

Actions #1

Updated by François ARMAND over 10 years ago

  • Category set to Web - UI & UX
  • Status changed from New to In progress
  • Assignee set to François ARMAND

Assigning myself for the merging management.

Actions #2

Updated by François ARMAND over 10 years ago

Thanks for the contribution.

Could you check if some of the correction are valid correction in earlier release (branches/rudder/2.4, branches/rudder/2.6, branches/rudder/2.7, branches/rudder/2.8, branches/rudder/2.9 ?)

And if so, create a new pull request for the correct branches ?

Thanks,

Actions #3

Updated by Dennis Cabooter over 10 years ago

I think I already did that. If not, can you explain me how to do it?

Actions #4

Updated by Vincent MEMBRÉ about 10 years ago

  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Target version set to 2.6.10

I'm reatargeting pull requests:

Dennis here is the command i ran:

# Get on branch I need to rebase
git checkout branches/rudder/2.6

# Checkout on new branch, so my code branches are still in synch with central repo
git checkout -b bug/4206/correct_english

# One cherry-pick for each, stating from the oldest commit
git cherry-pick <commit-hash> # got it using git log on your master branch

# Optionnal, I renamed the commit starting with: Refs #4206 so redmine will link the commit to that issue
git rebase -i branches/rudder/2.6 #option r for each file

Actions #5

Updated by Dennis Cabooter about 10 years ago

  • Status changed from In progress to Pending release
  • % Done changed from 0 to 100

Applied in changeset rudder-doc:commit:bc8c39da0844b8c1c9e6a3d903b6aaf805fb4c75.

Actions #6

Updated by Vincent MEMBRÉ about 10 years ago

Applied in changeset rudder-doc:commit:e0e68c669d3a3e02ceb3a9a15add073d60182e2c.

Actions #7

Updated by Vincent MEMBRÉ about 10 years ago

  • Status changed from Pending release to Discussion
  • % Done changed from 100 to 0
Actions #8

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.6.10 to 2.6.11
Actions #9

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.6.11 to 2.6.10
Actions #10

Updated by Vincent MEMBRÉ about 10 years ago

  • Status changed from Discussion to Rejected
Actions #11

Updated by Vincent MEMBRÉ about 10 years ago

  • Status changed from Rejected to Pending release
Actions #12

Updated by Vincent MEMBRÉ about 10 years ago

  • Subject changed from Incorrect English grammar to Incorrect English grammar in documentation
Actions #13

Updated by Vincent MEMBRÉ about 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.6.10 which was released today.
Check out:

Actions

Also available in: Atom PDF