User story #4100
closed
User story #4079: When Rudder does not start due to an error in rudder-users.xml, the webapp will display an usable error log
Improve log when users xml is not valid
Description
When rudder-users.xml is not valid, the webapp send a massive execption where real information is very hard to find.
We should improve it by logging an error message:
[2013-10-22 17:40:01] ERROR application - Rudder user xml: An error occured while parsing the users xml file, and you won't be able to connect to Rudder webapp until you correct it and restarted Rudder webapp. [2013-10-22 17:40:01] ERROR application - Rudder user xml: xml file is not correct, error message is: Le type d'élément "user" doit se terminer par la balise de fin correspondante "</user>". (line 105, column 3)
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from In progress to 10
- Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
Jon, what do you think of those log message ?
Rudder user xml: An error occured while parsing the users xml file, and you won't be able to connect to Rudder webapp until you correct it and restarted Rudder webapp. Rudder user xml: xml file is not correct, error message is: Le type d'élément "user" doit se terminer par la balise de fin correspondante "</user>". (line 105, column 3)
Updated by Vincent MEMBRÉ over 10 years ago
- Pull Request set to https://github.com/Normation/rudder/pull/356
Updated by Vincent MEMBRÉ over 10 years ago
- Assignee changed from Jonathan CLARKE to François ARMAND
I changed the message and forced the Locale to be in english for this message.
Result is:
[2013-10-23 10:47:09] ERROR application - User definitions: An error occured while parsing /opt/rudder/etc/rudder-users.xml. Logging in to the Rudder web interface will not be possible until this is fixed and the application restarted. [2013-10-23 10:47:09] ERROR application - User definitions: XML in file /opt/rudder/etc/rudder-users.xml is incorrect, error message is: The element type "user" must be terminated by the matching end-tag "</user>". (line 105, column 3)
Going to technical review (but can't change it :()
Pull request here: https://github.com/Normation/rudder/pull/356
Updated by François ARMAND over 10 years ago
- Status changed from 10 to Pending technical review
Updated by François ARMAND over 10 years ago
- Status changed from Pending technical review to In progress
- Assignee changed from François ARMAND to Vincent MEMBRÉ
Remarks in the pr!
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from In progress to 10
- Assignee changed from Vincent MEMBRÉ to François ARMAND
Remarks adressed! going back to technical review.
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from 10 to Pending release
- % Done changed from 0 to 100
Applied in changeset 857fa1de96409e7977274050418d7de1d78239a4.
Updated by Anonymous over 10 years ago
Applied in changeset e39405b27ab8680cde1b25019c652ceee6ecb1f4.
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.8.0~rc1, which was released on Friday 25/10/2013.
Check out:
- The release announcement: http://www.rudder-project.org/pipermail/rudder-announce/2013-October/000057.html
- The full ChangeLog: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog28
- Download information: https://www.rudder-project.org/site/get-rudder/downloads/
Updated by Benoît PECCATTE about 9 years ago
- Category changed from 39 to System integration
Updated by Benoît PECCATTE about 9 years ago
- Tracker changed from Enhancement to User story