Project

General

Profile

Actions

Bug #3580

closed

'Copy file from shared folder' reporting is completly broken in 2.6

Added by Vincent MEMBRÉ almost 11 years ago. Updated about 9 years ago.

Status:
Released
Priority:
2
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Due to a misstake in merge beetween branch 2.5 and 2.6, reporting is broken in the version 1.3 of 'copy file from shared folder' Technique.

The technique is working fine, but the reporting is not working at all

in 2.5 :

  reports:
    !is_valid::
                "@@copyFile@@result_error@@$(copyfile[$(index)][uuid])@@Copy file@@$(copyfile[$(index)][name])@@$(g.execRun)##$(g.uuid)@#There is no shared folder on the Rudder Server, so it's not possible to copy a file from it";
    linux|windows::
                "@@copyFile@@result_success@@$(copyfile[$(index)][uuid])@@Copy file@@$(copyfile[$(index)][name])@@$(g.execRun)##$(g.uuid)@#The content of the file(s) is valid" 
                        ifvarclass => "copy_file_$(index)_kept.!copy_file_$(index)_modified";

2.6 :

  reports:
    (linux|windows).!is_valid::
      "@@copyFile@@result_error@@${copyfile[${index}][uuid]}@@Copy file@@${copyfile[${index}][name]}@@${g.execRun}##${g.uuid}@#There is no shared folder on the Rudder Server, so it's not possible to copy a file from it";

      "@@copyFile@@result_success@@${copyfile[${index}][uuid]}@@Copy file@@${copyfile[${index}][name]}@@${g.execRun}##${g.uuid}@#The content of the file(s) is valid" 
        ifvarclass => "copy_file_${index}_kept.!copy_file_${index}_modified";

the classes should be splitted to be like 2.5

Actions #1

Updated by Vincent MEMBRÉ almost 11 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/123
Actions #2

Updated by Vincent MEMBRÉ almost 11 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:b3b46bbf7e4933e2b006dfd8b56112fd0abc4ec5.

Actions #3

Updated by Nicolas CHARLES almost 11 years ago

Applied in changeset commit:e51b7ad99746a7478c6775972f2d63a33b137290.

Actions #4

Updated by Vincent MEMBRÉ almost 11 years ago

  • Status changed from Pending release to Released

This ticket has been adressed in the 2.6.1 release of Rudder.

The ChangeLog is available here: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog26

Actions #5

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions

Also available in: Atom PDF