Bug #3159: The database management displays an error when no database archive has ever been made - Rudder - Issue Tracker

Actions

Copy link

Bug #3159

closed

The database management displays an error when no database archive has ever been made

Added by Matthieu CERDA over 11 years ago. Updated about 11 years ago.

Status:

Released

Priority:

Assignee:

François ARMAND

Category:

Web - Maintenance

Target version:

2.4.3

Pull Request:

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

While accessing the database management on a production Rudder machine (2.4.0rc2), I get this error:

Archived reports
Oldest archived report:     There's been an error with the database, could not fetch the value
Newest archived report:     There's been an error with the database, could not fetch the value

I am pretty sure that this "There's been an error with the database, could not fetch the value" should be "never" instead.

Note: The rudderarchivedsysevents table is here, but empty.

Actions

Copy link

Updated by François ARMAND over 11 years ago

Status changed from New to 8
Assignee changed from François ARMAND to Vincent MEMBRÉ

Matthieu, you are right, and the problem lies in the signature of some method which does not into account that case:

def getOldestReports() : Box[Reports]
    def getOldestArchivedReports() : Box[Reports]
    def getNewestReports() : Box[Reports]
    def getNewestArchivedReports() : Box[Reports]

All these methods should have a return type: Box[Option[Reports]], Full[None] meaning "there was no error, but we don't have any reports yet".

Actions

Copy link

Updated by Vincent MEMBRÉ over 11 years ago

Is it not better to use a Box[Reports] and to match the Empty Case with "there was no error, but we don't have any reports yet" and the failure case with "There's been an error with the database, could not fetch the value" ?

Actions

Copy link