Project

General

Profile

Actions
Copy link

Architecture #3028

closed

Make the CFEngine process checking promise in Rudder more clean and targeted

Added by Matthieu CERDA over 11 years ago. Updated over 11 years ago.

Status:
Released
Priority:
3
Assignee:
Matthieu CERDA
Category:
System techniques
Target version:
2.5.0~beta1
Pull Request:
Effort required:
Name check:
Fix check:
Regression:

Description

Make the CFEngine process checking promise in Rudder more clean and targeted.

As of now, this promise contains a lot of code duplication, and targets ALL the CFEngine processes (even the currently running one.)

We should avoid this and make it more clean.

Pull request linked to this US: https://github.com/Normation/rudder-techniques/pull/4

Files

process_select_in_promises_st.patch (1.62 KB) process_select_in_promises_st.patch Matthieu CERDA, 2012-11-26 19:09
Actions
Copy link
 #1

Updated by Matthieu CERDA over 11 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Matthieu CERDA over 11 years ago

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100

Pull request available, to be reviewed.

Actions
Copy link
 #3

Updated by Matthieu CERDA over 11 years ago

I removed the feature Jon was talking about in the diff (the process_select), but this feature also applies to this user story as well. Should I add a subtask to this ticket ?

Enclosed to this comment is the patch to apply this new feature, for easier review and applying later.

Actions
Copy link
 #4

Updated by Nicolas CHARLES over 11 years ago

  • Status changed from Pending technical review to 10

The pull request has been merged

Actions
Copy link
 #5

Updated by Nicolas CHARLES over 11 years ago

  • Status changed from 10 to Released

Thank you Matthieu !

Actions
Copy link
 #6

Updated by Jonathan CLARKE over 11 years ago

  • Tracker changed from User story to Architecture
Actions
Copy link
 #7

Updated by Jonathan CLARKE over 11 years ago

  • Status changed from Released to Pending release
Actions
Copy link
 #8

Updated by Jonathan CLARKE over 11 years ago

Matthieu CERDA wrote:

I removed the feature Jon was talking about in the diff (the process_select), but this feature also applies to this user story as well. Should I add a subtask to this ticket ?

Enclosed to this comment is the patch to apply this new feature, for easier review and applying later.

No, this is a different change. Please create a new ticket and explain the logic behind your suggestion (and make a pull request with the patch, of course :) )

Actions
Copy link
 #9

Updated by Jonathan CLARKE over 11 years ago

  • Target version changed from 2.4.0~rc2 to 2.5.0~beta1

This was NOT on 2.4 branch, but on master! Please pay attention to target versions...

Actions
Copy link
 #10

Updated by Matthieu CERDA over 11 years ago

  • Status changed from Pending release to Released
Actions
Copy link

Also available in: Atom PDF