Project

General

Profile

Actions

Bug #2946

closed

Resync Rudder"s APT installation promises with the new stdlib to prevent non interactive installation failures

Added by Matthieu CERDA over 11 years ago. Updated over 11 years ago.

Status:
Released
Priority:
1
Assignee:
Matthieu CERDA
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The new stdlib contains fixes to prevent apt from failing on new configuration files/modified ones. We should use it.

Actions #1

Updated by Matthieu CERDA over 11 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100

All clear, I sync'ed the promises and the stdlib in all branches !

Actions #2

Updated by Nicolas PERRON over 11 years ago

Seems OK to me. Besides, these modifications came from the cfengine_stdlib

Actions #5

Updated by Jonathan CLARKE over 11 years ago

  • Status changed from Pending technical review to Discussion

This looks OK, but there is one weirdness I don't understand: in aptPackageInstallation you have removed the "-q" option to the package_delete_command, but in distributePolicy, you have added it. Why this difference? Should they not be consistent?

Actions #6

Updated by Matthieu CERDA over 11 years ago

You are right, it should totally be consistent. The stdlib uses a -q, so I will add it. It must be a copy paste glitch ...

Actions #7

Updated by Matthieu CERDA over 11 years ago

  • Status changed from Discussion to Pending technical review

And, it has been corrected. Thanks for beeing so sharp-eyed !

Actions #8

Updated by Jonathan CLARKE over 11 years ago

OK, this looks good.

But, PLEASE do not commit the same change to several branches! Ever. Your role, as a developer on this project, is to commit a bug fix to the earliest branch affected by the issue. We have automatic tools to merge fixed "upwards" to other branches. Having multiple commits make the code review task a lot harder, and makes tracking the commit later on difficult, since we basically have 3 duplicate commits (this is equivalent to duplicating code, in that it is not DRY).

Actions #9

Updated by Jonathan CLARKE over 11 years ago

  • Status changed from Pending technical review to Released
Actions

Also available in: Atom PDF