Project

General

Profile

Actions

Bug #2693

closed

When creating a new rule, display edit parameters tab

Added by Vincent MEMBRÉ over 11 years ago. Updated over 11 years ago.

Status:
Released
Priority:
4
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

when creating a rule, we want to set its parameters, so instead of displaying compliance tab we should display edit parameters tab

Actions #1

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100
Actions #2

Updated by Nicolas CHARLES over 11 years ago

  • Status changed from Pending technical review to Discussion
  • % Done changed from 100 to 80

Vincent, I have two questions about this one :
- Why did you declare some "implicit" in you method definition ? Implicit is used to fetch values from the scope ( http://daily-scala.blogspot.fr/2010/04/implicit-parameters.html ), but I don't see why it is used here (simply the tab:Int = 0 whould be sufficient)
- In Replace("editRuleZone", this.showForm(1) ), why did you replace the htmlId by a string ? I feel there must be something tricky that I don't get

Thank you

Actions #3

Updated by Vincent MEMBRÉ over 11 years ago

- Why did you declare some "implicit" in you method definition ? Implicit is used to fetch values from the scope ( http://daily-scala.blogspot.fr/2010/04/implicit-parameters.html ), but I don't see why it is used here (simply the tab:Int = 0 whould be sufficient)

You are right, i did what you suggest, but i made a mistake when calling my function later (forgot parenthesis ...), i removed the implicit and fix everything

- In Replace("editRuleZone", this.showForm(1) ), why did you replace the htmlId by a string ? I feel there must be something tricky that I don't get

the target of replace has changed with the detail tab, I just add the raw id, i created a val for that id

Thank you !

Actions #4

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from Discussion to Pending technical review
  • % Done changed from 80 to 100
Actions #5

Updated by Nicolas CHARLES over 11 years ago

  • Status changed from Pending technical review to Released

This looks correct, thank you Vincent

Actions

Also available in: Atom PDF