Project

General

Profile

Actions

Bug #2686

closed

The "Rule Added" event log is not displayed correctly

Added by Jean VILVER almost 12 years ago. Updated over 11 years ago.

Status:
Released
Priority:
N/A
Assignee:
Jean VILVER
Category:
Web - Maintenance
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When we click on the table line, no further information is displayed.

Actions #1

Updated by Jean VILVER almost 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100
Actions #2

Updated by Nicolas CHARLES almost 12 years ago

  • Status changed from Pending technical review to In progress
  • % Done changed from 100 to 80

Jean, I don't agree with your modifications in the EventListDisplayer.scala : you are trying to match Nil with a Seq, but Nil is List-specific ( http://www.scala-lang.org/node/9951 ); if you really want to pattern match with Nil, you need to do a toList rather than a toSeq; but still I don't see the point of this modification

The rest of the commit is ok

Actions #3

Updated by Jean VILVER almost 12 years ago

Nicolas CHARLES wrote:

Jean, I don't agree with your modifications in the EventListDisplayer.scala : you are trying to match Nil with a Seq, but Nil is List-specific ( http://www.scala-lang.org/node/9951 ); [...]

toSeq() produce a List(), so I'm matching Nil with a List which is good.
But I still changed the matching in cc78adc87f5541f56a5cce48f1f88b4425c4bf14.

Actions #4

Updated by Jean VILVER almost 12 years ago

  • Status changed from In progress to Pending technical review
Actions #5

Updated by Nicolas CHARLES almost 12 years ago

Jean VILVER wrote:

toSeq() produce a List(), so I'm matching Nil with a List which is good.

No, toSeq() produce a List() only with certain types of Seq

Actions #6

Updated by Nicolas CHARLES almost 12 years ago

  • Status changed from Pending technical review to Released

This correction is correct, thank you Jean

Actions #7

Updated by Jean VILVER over 11 years ago

  • % Done changed from 80 to 100
Actions

Also available in: Atom PDF