Project

General

Profile

Actions

Architecture #2669

closed

Merge node and root initial promises in order to use rudder-agent with rudder server

Added by Nicolas PERRON over 11 years ago. Updated about 9 years ago.

Status:
Released
Priority:
1
Assignee:
Nicolas PERRON
Category:
Packaging
Target version:
Effort required:
Name check:
Fix check:
Regression:

Description

Since we're trying to let the server be managed by itself (#1971), we need to use rudder-agent instead of rudder-cfengine-community (#2668). Nevertheless, using rudder-agent result in the installation of inital-promises.

As rudder-agent will be used by nodes and servers and we cannot now if the machine will be a node or a server, we have to use the same files. The disctinction will be in these initial promises which will be executed differently on the nodes and the server.


Related issues 6 (0 open6 closed)

Related to Rudder - Bug #2670: The intial promises are not up to dateReleasedNicolas PERRON2012-07-19Actions
Related to Rudder - Bug #2742: promises.cf generated on the nodes must contains bundlesequence calling to 'check_log_system' and 'e2s_enable' in order to send reports to the serverReleasedNicolas PERRON2012-07-31Actions
Related to Rudder - Bug #2744: promises.cf generated on the nodes must contains bundlesequence calling to 'check_red_button_status' and 'check_uuid' in order to check that CFEngine continue to apply the promisesReleasedNicolas PERRON2012-07-31Actions
Related to Rudder - Bug #2923: promises.cf generated on the nodes must contains bundlesequence calling to 'set_red_button' and 'clean_red_button' in order to use red button feature on nodesReleasedNicolas PERRON2012-09-21Actions
Precedes Rudder - Architecture #2668: Replace rudder-cfengine-community by rudder-agent for the packages required with rudder-server-rootReleasedNicolas PERRON2012-07-202012-07-20Actions
Precedes Rudder - User story #1971: Impossible to manage rudder server via web interfaceReleasedNicolas PERRON2012-07-212012-07-21Actions
Actions #1

Updated by Nicolas PERRON over 11 years ago

The initial promises are located in the rudder-techniques repository.

First of all, we must ensure that the same files in rudder-techniques/initial-promises/nodeInitialPromises/ and rudder-techniques/initial-promises/rootServerInitialPromises/cfengine-community/ are at the same version, the same content:

# tree nodeInitialPromises/
nodeInitialPromises/
├── common
│   └── 1.0
│       ├── cfengine_stdlib.cf
│       ├── core-lib.cf
│       ├── library.cf
│       ├── process_matching.cf
│       ├── site.cf
│       └── update.cf
├── failsafe.cf
├── inventory
│   └── 1.0
│       ├── fetchFusionTools.cf
│       ├── fusionAgent.cf
│       └── virtualMachines.cf
└── promises.cf

4 directories, 11 files
# tree rootServerInitialPromises/cfengine-community/
rootServerInitialPromises/cfengine-community/
├── common
│   └── 1.0
│       ├── cfengine_stdlib.cf
│       ├── cf-served.cf
│       ├── internal_security.cf
│       ├── process_matching.cf
│       ├── rudder_lib.cf
│       ├── site.cf
│       └── update.cf
├── distributePolicy
│   ├── 1.0
│   │   ├── aliveCheck.cf
│   │   ├── apacheCheck.cf
│   │   ├── initCheck.cf
│   │   ├── integrityCheck.cf
│   │   ├── ldapCheck.cf
│   │   ├── logrotateCheck.cf
│   │   ├── postgresCheck.cf
│   │   ├── propagatePromises.cf
│   │   └── rsyslogConf.cf
│   ├── logrotate.conf
│   │   └── rudder
│   └── rsyslog.conf
│       └── rudder.conf
├── failsafe.cf
└── promises.cf

6 directories, 20 files
Actions #2

Updated by Nicolas PERRON over 11 years ago

It will be difficult to merges these files. Each of them are differents in many way. Shouldn't be indentical ?
Example files:
  • initial-promises/nodeInitialPromises/common/1.0/update.cf
  • rootServerInitialPromises/cfengine-community/common/1.0/update.cf
  • rootServerInitialPromises/cfengine-nova/common/update.cf
  • policies/system/common/1.0/update.st
Actions #3

Updated by Nicolas PERRON over 11 years ago

Before all of this, It will be necessary to update all the initial-promises => #2670

Actions #4

Updated by Nicolas PERRON over 11 years ago

  • Status changed from New to In progress

There is a part about red button in the initial promise promise.cf for root server but not in the node. Given that Red button is an abandoned functionnality, should we keep it ?

Actions #5

Updated by Jonathan CLARKE over 11 years ago

Nicolas PERRON wrote:

There is a part about red button in the initial promise promise.cf for root server but not in the node. Given that Red button is an abandoned functionnality, should we keep it ?

Yes, it would be good to preserve this, because we only abandoned it because the UI was unsuitable. The CFEngine side was fine, so let's keep it working if possible.

Actions #6

Updated by Nicolas PERRON over 11 years ago

  • % Done changed from 0 to 80

The promises seems to be completely merged, except for nova.

Actions #7

Updated by Jonathan CLARKE over 11 years ago

All commits up to now look good to me.

I have just one concern: the inventory promises are not called on a policy_server, although they now should be.

Actions #8

Updated by Nicolas PERRON over 11 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 80 to 100

Jonathan CLARKE wrote:

All commits up to now look good to me.

I have just one concern: the inventory promises are not called on a policy_server, although they now should be.

It's done. the policy server should now be able to send it's own inventory !

As #2670, the CFengine Nova part has been moved into our internal bugtracker in order to not keep blocking this isssue. We can consider this over.

Actions #9

Updated by Nicolas PERRON over 11 years ago

I've added some corrections and one particularly:
  • inputs instruction can't be subject to CFEngine classes, so I've use an inputs which included all promises needed by server and nodes . Only bundlesquence continue to be subject of CFEngine classes and it's sufficient.
Actions #10

Updated by Matthieu CERDA over 11 years ago

It looks good to me. I do not see any suspicious things in the commits and in the resulting files on the repo. However, special care has to be observer as this is quite a large commit, be careful of side effects.

Actions #12

Updated by Jonathan CLARKE over 11 years ago

  • Status changed from Pending technical review to Released

This is a quite complicated, and I reviewed a lot of it as it happened. It all looks good to me.

Actions #13

Updated by Jonathan CLARKE over 11 years ago

  • Status changed from Released to Discussion

Jonathan CLARKE wrote:

This is a quite complicated, and I reviewed a lot of it as it happened. It all looks good to me.

Actually, no, commit:d89cc306a3843192f36c77a249c6aa0df9406136 introduced some problems with the bundlesequence in techniques, not in the initial promises. Issues #2742 and #2744 re-introduce 4 of the 6 bundles removed for nodes (non-policy-servers).

The two remaining ones that were removed are "set_red_button" and "clean_red_button". It seems to me that these should be included on nodes just the same as on policy_servers, since they include instructions to add/remove the "stopFile" which is what allows to completely pause CFEngine. Thoughts?

Actions #14

Updated by Nicolas PERRON over 11 years ago

Jonathan CLARKE wrote:

Jonathan CLARKE wrote:

This is a quite complicated, and I reviewed a lot of it as it happened. It all looks good to me.

Actually, no, commit:d89cc306a3843192f36c77a249c6aa0df9406136 introduced some problems with the bundlesequence in techniques, not in the initial promises. Issues #2742 and #2744 re-introduce 4 of the 6 bundles removed for nodes (non-policy-servers).

The two remaining ones that were removed are "set_red_button" and "clean_red_button". It seems to me that these should be included on nodes just the same as on policy_servers, since they include instructions to add/remove the "stopFile" which is what allows to completely pause CFEngine. Thoughts?

You're right ! The bundle check_red_button_status seems to be useless without set_red_button and clean_red_button. Besides, classes are already define to split between policy server and nodes actions.

Actions #15

Updated by Jonathan CLARKE over 11 years ago

Nicolas PERRON wrote:

Jonathan CLARKE wrote:

Jonathan CLARKE wrote:

This is a quite complicated, and I reviewed a lot of it as it happened. It all looks good to me.

Actually, no, commit:d89cc306a3843192f36c77a249c6aa0df9406136 introduced some problems with the bundlesequence in techniques, not in the initial promises. Issues #2742 and #2744 re-introduce 4 of the 6 bundles removed for nodes (non-policy-servers).

The two remaining ones that were removed are "set_red_button" and "clean_red_button". It seems to me that these should be included on nodes just the same as on policy_servers, since they include instructions to add/remove the "stopFile" which is what allows to completely pause CFEngine. Thoughts?

You're right ! The bundle check_red_button_status seems to be useless without set_red_button and clean_red_button. Besides, classes are already define to split between policy server and nodes actions.

OK, cool. Then please open a new bug for this and fix in 2.4.0~beta5. This one can then be closed.

Actions #16

Updated by Nicolas PERRON over 11 years ago

Jonathan CLARKE wrote:

Nicolas PERRON wrote:

Jonathan CLARKE wrote:

Jonathan CLARKE wrote:

This is a quite complicated, and I reviewed a lot of it as it happened. It all looks good to me.

Actually, no, commit:d89cc306a3843192f36c77a249c6aa0df9406136 introduced some problems with the bundlesequence in techniques, not in the initial promises. Issues #2742 and #2744 re-introduce 4 of the 6 bundles removed for nodes (non-policy-servers).

The two remaining ones that were removed are "set_red_button" and "clean_red_button". It seems to me that these should be included on nodes just the same as on policy_servers, since they include instructions to add/remove the "stopFile" which is what allows to completely pause CFEngine. Thoughts?

You're right ! The bundle check_red_button_status seems to be useless without set_red_button and clean_red_button. Besides, classes are already define to split between policy server and nodes actions.

OK, cool. Then please open a new bug for this and fix in 2.4.0~beta5. This one can then be closed.

Done. See #2923

Actions #17

Updated by Jonathan CLARKE over 11 years ago

  • Status changed from Discussion to Released
Actions #18

Updated by Nicolas PERRON about 11 years ago

  • Project changed from Rudder to 34
  • Category deleted (11)
Actions #19

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions

Also available in: Atom PDF