Project

General

Profile

Actions

User story #2394

closed

Make the base template used in the hosts configuration Technique for a hosts file reset configurable

Added by Matthieu CERDA about 12 years ago. Updated almost 12 years ago.

Status:
Released
Priority:
5
Assignee:
Matthieu CERDA
Category:
Techniques
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

The hosts file template that the hosts configuration technique uses to fill the hosts file when a file purge is requested should be configurable (using a textarea in the metadata.xml)

Actions #1

Updated by Matthieu CERDA about 12 years ago

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:7693f946d22eb060cf323a303c474b565c0e0a69.

Actions #2

Updated by Jonathan CLARKE almost 12 years ago

  • Status changed from Pending technical review to 10

This looks correct to me.

Actions #3

Updated by Jonathan CLARKE almost 12 years ago

  • Status changed from 10 to Discussion
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA

Actually, no, this is not OK. A change that adds a variable to the PT should be done in a new version of the PT, otherwise Rudder will try and generate .cf files but not have a value for the variable!

Also, this should have been committed on the 2.3 branch.

Actions #4

Updated by Jonathan CLARKE almost 12 years ago

For now, I'm reverting this commit as it does more harm than good. Matthieu, please re-use the original diff (git diff) to fix this, in a new version. Thanks.

Actions #5

Updated by Jonathan CLARKE almost 12 years ago

  • Target version changed from 2.4.0~alpha7 to 2.3.8
Actions #6

Updated by Matthieu CERDA almost 12 years ago

  • Status changed from Discussion to Pending technical review

Fixed in commit commit:aae95486fb25895a65292bd468515b7319def281

Actions #7

Updated by Jonathan CLARKE almost 12 years ago

  • Status changed from Pending technical review to 10

Looks good to me, thanks.

Actions #8

Updated by Jonathan CLARKE almost 12 years ago

  • Status changed from 10 to Released
Actions

Also available in: Atom PDF