Project

General

Profile

Actions

Bug #2258

closed

Event log for changes to Policy Instance Common is incomplete

Added by Jonathan CLARKE about 12 years ago. Updated almost 12 years ago.

Status:
Released
Priority:
2
Category:
System techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

If I add an allowed network to my Rudder server in http://rudder-snapshot.normation.com/rudder/secure/administration/policyServerManagement, then I look at the event logs, I see the output below.

This is missing multiple values for allowed networks - I actually have 3, but only 1 is displayed.


Files

Screenshot-1.png (70.1 KB) Screenshot-1.png Jonathan CLARKE, 2012-02-09 11:18
Actions #1

Updated by François ARMAND about 12 years ago

  • Category changed from Web - Maintenance to System techniques
  • Status changed from 2 to Discussion
  • Assignee set to Jonathan CLARKE

The problem seems to be with the policy.xml of Common: there is some variable in it which are multivalued, not defined in multivalued section.

(see internal archive for multivalued section in subsection, for example old #1416 or #1533)

Adding a <SECTION name="authorizedNetworks" multivalued="true"> around input "ALLOWEDNETWORK" solve the display bug, but I can't say it does not brings other problems.

Actions #2

Updated by François ARMAND about 12 years ago

  • Status changed from Discussion to In progress

I'm going to add the relevant section, and one versed in CFEngine will have to see if the world does not end after that modification.

Actions #3

Updated by François ARMAND about 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100

Applied in changeset commit:7f4a95fd1854cb27617c8d6887e7b09f7d5844a5.

Actions #4

Updated by Jonathan CLARKE about 12 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to François ARMAND

François ARMAND wrote:

I'm going to add the relevant section, and one versed in CFEngine will have to see if the world does not end after that modification.

This modification looks fine. It won't affect the generated promises at all, as we use the variables based solely on their name, not on their section. Reporting used the section names, but all reports use other sections that were already defined.

However, shouldn't you remove "<MULTIVALUED>true</MULTIVALUED>" too? I thought this was deprecated now.

Actions #5

Updated by François ARMAND about 12 years ago

  • Status changed from Discussion to In progress

Yes, you're right. no other policy.xml has that anymore.

Actions #6

Updated by François ARMAND about 12 years ago

  • Status changed from In progress to Pending technical review

Applied in changeset commit:fc82b4d725ce4e3fde4bfe9e7a017547460a046c.

Actions #7

Updated by Nicolas CHARLES about 12 years ago

  • Status changed from Pending technical review to Released

This is valid, thank you Francois !

Actions #8

Updated by Jonathan CLARKE almost 12 years ago

  • Target version changed from 2.4.0~alpha5 to 2.3.7

This bug also applied to the 2.3 branch, so I've backported the commits.

Actions

Also available in: Atom PDF