Project

General

Profile

Actions
Copy link

Architecture #2115

closed

Factor out success pop-up

Added by François ARMAND over 12 years ago. Updated about 12 years ago.

Status:
Released
Priority:
3
Assignee:
Arthur ANGLADE
Category:
Web - UI & UX
Target version:
2.4.0~alpha2
Pull Request:
Effort required:
Name check:
Fix check:
Regression:

Description

In a lot of place, both in HTML and in JS, we have the same code for the "success pop-up".

All that code should be defined in only one place!

  • the "success" pop-up HTML should be in the common-layout template, always available;
  • the js fonction displaying it should be in our js file.
Actions
Copy link
 #1

Updated by Arthur ANGLADE over 12 years ago

  • Status changed from 2 to Pending technical review
  • % Done changed from 0 to 100
Actions
Copy link
 #2

Updated by Nicolas CHARLES about 12 years ago

  • Status changed from Pending technical review to 10

This seems valid, thank you Arthur

Actions
Copy link
 #3

Updated by Jonathan CLARKE about 12 years ago

  • Status changed from 10 to Released

Closing these "Architecture" issues without a functional review - this step of the workflow has no sense here, there is no functional impact on code architecture changes (or there shouldn't be anyway!).

I think we should remove this step from the workflow for Architecture issues.

Actions
Copy link

Also available in: Atom PDF