Project

General

Profile

Bug #1528

Cancel button on pop-up fire an AJAX request and sometimes lag

Added by François ARMAND almost 7 years ago. Updated about 1 year ago.

Status:
Rejected
Priority:
4
Assignee:
-
Category:
Architecture - Refactoring
Target version:
Target version (plugin):
Severity:
Trivial - no functional impact | cosmetic
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Pull Request:
Priority:
31

Description

For (all ?) pop-up used to create items, like "configuration rule creation pop-up", the cancel button should only close the pop-up, a pure JS, client-side event. But currently, they fire an Ajax request, that does nothing (safe spending time one server and leading to some client side lag).

=> replace SHtml.ajaxButton("Cancel", { () => closePopup() }) by something like: <button onclick="closePopup();return false;">Cancel</button>

History

#1 Updated by Jonathan CLARKE almost 7 years ago

  • Target version changed from 16 to 19

#2 Updated by François ARMAND almost 7 years ago

  • Assignee set to François ARMAND

#3 Updated by Jonathan CLARKE almost 7 years ago

  • Target version changed from 19 to 21

#4 Updated by Jonathan CLARKE almost 7 years ago

  • Target version changed from 21 to 23

#5 Updated by Jonathan CLARKE almost 7 years ago

  • Target version changed from 23 to 18

#6 Updated by François ARMAND over 6 years ago

  • Target version changed from 18 to 24

#7 Updated by Jonathan CLARKE about 6 years ago

  • Target version changed from 24 to Ideas (not version specific)

#8 Updated by François ARMAND over 5 years ago

  • Assignee deleted (François ARMAND)

#9 Updated by Nicolas CHARLES over 3 years ago

  • Status changed from New to 8
  • Assignee set to Nicolas CHARLES
  • Target version changed from Ideas (not version specific) to 2.10.8

#10 Updated by Nicolas CHARLES over 3 years ago

Hum, i can prevent having a post+get, to have only an empty post, but i'm don't know how to do better than that...

#11 Updated by Nicolas CHARLES over 3 years ago

even hardcoding the button in the template and removing everything on scala will still trigger a post, as it is inside a form that we close
i'm not sure which solution i should use...

#12 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.10.8 to 2.10.9

#13 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.10.9 to 2.10.10

#14 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.10.10 to 2.10.11

#15 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.10.11 to 2.10.12

#16 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.10.12 to 2.10.13

#17 Updated by Nicolas CHARLES over 3 years ago

  • Assignee changed from Nicolas CHARLES to François ARMAND

i'm reassigning this ticket to you Francois, as I couldn't fix it

#18 Updated by Benoît PECCATTE over 3 years ago

  • Status changed from 8 to New

#19 Updated by François ARMAND over 3 years ago

  • Reproduced set to Yes

#20 Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 2.10.13 to 2.10.14

#21 Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 2.10.14 to 2.10.15

#22 Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 2.10.15 to 2.10.16

#23 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.10.16 to 2.10.17

#24 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.10.17 to 2.10.18

#25 Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 2.10.18 to 2.10.19

#26 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.10.19 to 2.10.20

#27 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.10.20 to 2.11.18

#28 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.18 to 2.11.19

#29 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.19 to 2.11.20

#30 Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 2.11.20 to 2.11.21

#31 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.21 to 2.11.22

#32 Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 2.11.22 to 2.11.23

#33 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 2.11.23 to 2.11.24

#34 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 2.11.24 to 308

#35 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 308 to 3.1.14

#36 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.14 to 3.1.15

#37 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.15 to 3.1.16

#38 Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 3.1.16 to 3.1.17

#39 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.17 to 3.1.18

#40 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.18 to 3.1.19

#41 Updated by François ARMAND over 1 year ago

  • Subject changed from Cancel button on pop-up fire an AJAX request to Cancel button on pop-up fire an AJAX request and sometimes lag
  • Description updated (diff)
  • Severity set to Trivial - no functional impact | cosmetic
  • User visibility set to Getting started - demo | first install | level 1 Techniques

#42 Updated by Benoît PECCATTE over 1 year ago

  • Priority set to 31

#43 Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 3.1.19 to 3.1.20

#44 Updated by Jonathan CLARKE about 1 year ago

  • Assignee deleted (François ARMAND)

#45 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 3.1.20 to 3.1.21

#46 Updated by Raphael GAUTHIER about 1 year ago

  • Status changed from New to Rejected

This bug doesn't appear anymore.
Rejecting

Also available in: Atom PDF