Project

General

Profile

Actions

Bug #11299

closed

There is no correct error handling in rpkg

Added by Nicolas CHARLES over 6 years ago. Updated over 3 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
-
Category:
Packaging
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Small
Priority:
0
Name check:
Fix check:
Regression:

Description

When something goes bad when installing a Rudder plugin, all we get is a nasty stacktrace, like

Traceback (most recent call last):
  File "/opt/rudder/bin/rudder-pkg", line 331, in <module>
    install_file(args['<package.rpkg>'])
  File "/opt/rudder/bin/rudder-pkg", line 239, in install_file
    metadata = rpkg_metadata(package_file)
  File "/opt/rudder/bin/rudder-pkg", line 117, in rpkg_metadata
    return json.loads(output)
  File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Expecting property name: line 10 column 3 (char 231)

There's no way it helps in any way the user to understand what is going on, and it looks terrible

Actions #1

Updated by François ARMAND over 6 years ago

  • Target version set to 4.1.7
  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
  • Effort required set to Very Small
  • Priority changed from 0 to 49
Actions #3

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.7 to 4.1.8
Actions #4

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.8 to 4.1.9
  • Priority changed from 49 to 48
Actions #5

Updated by Benoît PECCATTE over 6 years ago

  • Priority changed from 48 to 60
Actions #6

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.9 to 4.1.10
  • Priority changed from 60 to 59
Actions #7

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.10 to 4.1.11
  • Priority changed from 59 to 57
Actions #8

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.11 to 4.1.12
  • Priority changed from 57 to 55
Actions #9

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.12 to 4.1.13
  • Priority changed from 55 to 54
Actions #10

Updated by Benoît PECCATTE almost 6 years ago

  • Target version changed from 4.1.13 to 411
Actions #11

Updated by Benoît PECCATTE almost 6 years ago

  • Target version changed from 411 to 4.1.13
Actions #12

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.13 to 4.1.14
  • Priority changed from 54 to 52
Actions #13

Updated by Benoît PECCATTE over 5 years ago

  • Target version changed from 4.1.14 to 4.1.15
  • Priority changed from 52 to 51
Actions #14

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.15 to 4.1.16
Actions #15

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions #16

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.17 to 4.1.18
  • Priority changed from 51 to 0
Actions #17

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 4.1.18 to 4.1.19
Actions #18

Updated by Alexis Mousset about 5 years ago

  • Target version changed from 4.1.19 to 4.1.20
Actions #19

Updated by François ARMAND about 5 years ago

  • Target version changed from 4.1.20 to 4.1.21
Actions #20

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 4.1.21 to 4.1.22
Actions #21

Updated by Benoît PECCATTE almost 5 years ago

  • Target version changed from 4.1.22 to 5.0.10
Actions #22

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 5.0.10 to 5.0.11
Actions #23

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 5.0.11 to 5.0.12
Actions #24

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.12 to 5.0.13
Actions #25

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.13 to 5.0.14
Actions #26

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.14 to 5.0.15
Actions #27

Updated by Alexis Mousset over 4 years ago

  • Effort required changed from Very Small to Small

Not very small. This may not be true in 6.0 anymore as rudder-pkg changed a lot.

Actions #28

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.15 to 5.0.16
Actions #29

Updated by Alexis Mousset about 4 years ago

  • Target version changed from 5.0.16 to 5.0.17
Actions #30

Updated by Vincent MEMBRÉ almost 4 years ago

  • Target version changed from 5.0.17 to 5.0.18
Actions #31

Updated by Alexis Mousset over 3 years ago

  • Status changed from New to Rejected

Error handling was improved a lot in rudder 6, closing.

Actions

Also available in: Atom PDF