Project

General

Profile

Bug #10908

When hooks in policy-generation-node-ready or policy-generation-node-finished fails, there is no error in the generation

Added by Nicolas CHARLES 5 months ago. Updated 5 months ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Target version (plugin):
Severity:
Major - prevents use of part of Rudder | no simple workaround
User visibility:
Effort required:
Priority:
0

Description

Error codes of hooks in policy-generation-node-ready or policy-generation-node-finished are not handled: if we return 1, it happily continues generation and finishes

It seems it's because return code is encapsulated in a Full - so it's always ok
So there is no real check on policy generation validity

Associated revisions

Revision d180e309
Added by François ARMAND 5 months ago

Fixes #10908: When hooks in policy-generation-node-ready or policy-generation-node-finished fails, there is no error in the generation

History

#1 Updated by François ARMAND 5 months ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND

#2 Updated by François ARMAND 5 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/1664

#3 Updated by François ARMAND 5 months ago

  • Status changed from Pending technical review to Pending release

#4 Updated by Alexis MOUSSET 5 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.4 which was not released (see changelog for details), and is available in Rudder 4.1.5.

Also available in: Atom PDF