Project

General

Profile

Bug #10860

Backup of apache vhost by rudder-server-relay created in bad directory

Added by Janos Mattyasovszky 6 months ago. Updated 3 months ago.

Status:
Released
Priority:
N/A
Category:
Packaging
Target version:
Target version (plugin):
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Very Small
Priority:
48

Description

The package 4.1.3 of rudder-server-relay creates backups of old files in plain /var/backups, while all other packages are using /var/backups/rudder:

# Move old virtual hosts out of the way
for OLD_VHOST in rudder-default rudder-default-ssl rudder-default.conf rudder-default-ssl.conf rudder-vhost.conf rudder-vhost-ssl.conf rudder-relay-vhost.conf
 rudder-relay-vhost-ssl.conf; do
        if [ -f /etc/apache2/vhosts.d/${OLD_VHOST} ]; then
                echo -n "INFO: An old rudder virtual host file has been detected (${OLD_VHOST}), it will be moved to /var/backups." 
                mkdir -p /var/backups
                mv /etc/apache2/vhosts.d/${OLD_VHOST} /var/backups/${OLD_VHOST}-$(date +%s)
                echo " Done" 
        fi
done

These are the paths that have /var/backups in the rpm's scripts:

# rpm -q --scripts -a rudder-* | grep -o '/var/backups/[^ ]*' | sort -u
/var/backups/${OLD_VHOST}-$(date                            <==== This is the only one not pointing to the rudder subdir.
/var/backups/rudder
/var/backups/rudder" 
/var/backups/rudder/cfengine_policy_server.dat-$(date
/var/backups/rudder/policy_server.dat-$(date
/var/backups/rudder/ppkeys-$(date
/var/backups/rudder/rudder-agent.$(basename
/var/backups/rudder/uuid-$(date

Is this behavior on purpose or simply by mistake?

Associated revisions

Revision 2931e348
Added by Alexis MOUSSET 4 months ago

Fixes #10860: Backup of apache vhost by rudder-server-relay created in bad directory

History

#1 Updated by François ARMAND 5 months ago

  • Severity changed from Trivial - no functional impact | cosmetic to Minor - inconvenience | misleading | easy workaround
  • Effort required set to Very Small
  • Priority changed from 0 to 35

#2 Updated by Alexis MOUSSET 5 months ago

  • Target version set to 4.1.5

#3 Updated by Alexis MOUSSET 5 months ago

  • Status changed from New to In progress
  • Assignee set to Alexis MOUSSET

#4 Updated by Alexis MOUSSET 5 months ago

  • Target version changed from 4.1.5 to 4.1.6

#5 Updated by Benoît PECCATTE 5 months ago

  • Priority changed from 35 to 49

#6 Updated by Alexis MOUSSET 4 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis MOUSSET to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1374

#7 Updated by Alexis MOUSSET 4 months ago

  • Status changed from Pending technical review to Pending release

#8 Updated by Vincent MEMBRÉ 3 months ago

  • Status changed from Pending release to Released
  • Priority changed from 49 to 48

This bug has been fixed in Rudder 4.1.6 and 4.2.0~beta3 which were released today.

Also available in: Atom PDF