Project

General

Profile

Bug #10859

Do not show instructions for rudder-node-to-relay on root setup

Added by Janos Mattyasovszky 4 months ago. Updated about 1 month ago.

Status:
Released
Priority:
N/A
Category:
Packaging
Target version:
Target version (plugin):
Severity:
Trivial - no functional impact | cosmetic
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Very Small
Priority:
62

Description

If you are installing a 4.1.3 root server, you get this output from rudder-server-relay:

*****************************************************************************************
INFO: rudder-server-relay setup complete.
INFO:
INFO: * If you are installing a root server, configuration is automatically done
INFO: * If you are installing a simple relay, run:
INFO:   '/opt/rudder/bin/rudder-node-to-relay root'
INFO:   on your root server to complete this node transition to a relay server.
INFO:   Please look at the documentation for details (Section 'Relay servers')
*****************************************************************************************

This is misleading, since a not-experienced user could think this is required (and only not documented) for the setup to work.

Good thing is rudder-node-to-relay does not allow you to screw up your ldap:

# /opt/rudder/bin/rudder-node-to-relay root
Rudder relay installation script starting, using UUID root.

INFO: The machine XXXXXXXXXXXXXX is already either a Rudder relay or root server.

Since you already display the uuid.hive, you could simply not display it if it is "root" (as shown in the output above):

# Do this ONLY at first install
if [ $1 -eq 1 ]
then
  echo "" 
  echo "*****************************************************************************************" 
  echo "INFO: rudder-server-relay setup complete.                                                " 
  echo "INFO:                                                                                    " 
  echo "INFO: * If you are installing a root server, configuration is automatically done         " 
  echo "INFO: * If you are installing a simple relay, run:                                       " 
  echo "INFO:   '/opt/rudder/bin/rudder-node-to-relay $(cat /opt/rudder/etc/uuid.hive)'          "   <== Here you got the uuid, simply do not show it if it is root
  echo "INFO:   on your root server to complete this node transition to a relay server.          " 
  echo "INFO:   Please look at the documentation for details (Section 'Relay servers')           " 
  echo "*****************************************************************************************" 
fi

Associated revisions

Revision af832398
Added by Benoît PECCATTE 3 months ago

Fixes #10859: Do not show instructions for rudder-node-to-relay on root setup

History

#1 Updated by François ARMAND 3 months ago

  • User visibility changed from First impressions of Rudder to Getting started - demo | first install | level 1 Techniques
  • Effort required set to Very Small
  • Priority changed from 0 to 49

As the message is produced by an other package than the one that brings uuid = root, we must be careful that perhaps the uuid is not already here. But at least, we could filter out the messages when we do know.

#2 Updated by Benoît PECCATTE 3 months ago

  • Priority changed from 49 to 64

#3 Updated by Benoît PECCATTE 3 months ago

  • Assignee set to Benoît PECCATTE

#4 Updated by Benoît PECCATTE 3 months ago

  • Target version set to 4.1.6

#5 Updated by Benoît PECCATTE 3 months ago

  • Status changed from New to In progress

#6 Updated by Benoît PECCATTE 3 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Alexis MOUSSET
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1366

#7 Updated by Benoît PECCATTE 3 months ago

  • Status changed from Pending technical review to Pending release

#8 Updated by Vincent MEMBRÉ about 1 month ago

  • Status changed from Pending release to Released
  • Priority changed from 64 to 62

This bug has been fixed in Rudder 4.1.6 and 4.2.0~beta3 which were released today.

Also available in: Atom PDF