Project

General

Profile

Bug #10773

Rounding error in compliance bar

Added by François ARMAND about 1 year ago. Updated 5 days ago.

Status:
New
Priority:
N/A
Assignee:
-
Category:
Web - UI & UX
Target version:
Target version (plugin):
Severity:
Critical - prevents main use of Rudder | no workaround | data loss | security
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Medium
Pull Request:
Priority:
64

Description

As reported in #10761, depending of the numbers, we may display percents that don't sum-up to 100% in the compliance bar.

A part of the ticket is to establish a definitive algo about how the computing of such rounding is done (up or down? Always 100 (yes)? Favors error or success?)


Related issues

Related to Rudder - Bug #12643: Compliance bar appears partially white in some graphesPending release

History

#1 Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 4.1.3 to 4.1.4

#2 Updated by Vincent MEMBRÉ 12 months ago

  • Target version changed from 4.1.4 to 4.1.5

#3 Updated by Alexis MOUSSET 11 months ago

  • Target version changed from 4.1.5 to 4.1.6

#4 Updated by Benoît PECCATTE 11 months ago

  • Priority changed from 35 to 50

#5 Updated by Benoît PECCATTE 11 months ago

Proposed algo:
  • Sort values from small to big
  • Have a counter for the rounding error (= displayed value - real value)
  • All values <1% are displayed <1% and counted as 1%
  • For each other value, round depending on the counter (above i negative, below if positive)

-> this should be as close to 100% as possible, more or less 1% (except if there are too many <1%
-> some value are not rounded to the closest

Alternative:
  • Idem except:
  • Round to the closest all values interdependently of the counter except the last one
  • Substract the counter from the last value before rounding

-> This can make sure we hit 100%
-> only the biggest value is imprecise

#6 Updated by Benoît PECCATTE 11 months ago

  • Category set to Web - UI & UX

#7 Updated by Raphael GAUTHIER 11 months ago

  • Effort required set to Medium
  • Priority changed from 50 to 33

#8 Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 4.1.6 to 4.1.7

#9 Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 4.1.7 to 4.1.8
  • Priority changed from 33 to 32

#10 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 4.1.8 to 4.1.9

#11 Updated by Benoît PECCATTE 7 months ago

  • Priority changed from 32 to 31

#12 Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 4.1.9 to 4.1.10

#13 Updated by Vincent MEMBRÉ 3 months ago

  • Target version changed from 4.1.10 to 4.1.11
  • Priority changed from 31 to 29

#14 Updated by Vincent MEMBRÉ about 1 month ago

  • Target version changed from 4.1.11 to 4.1.12

#15 Updated by Alexis MOUSSET 10 days ago

  • Severity changed from Minor - inconvenience | misleading | easy workaround to Critical - prevents main use of Rudder | no workaround | data loss | security
  • Priority changed from 29 to 64

It happens event in nodes list, and even in rules overview in node compliance. We need to go to component level to see errors.

This may hide any configuration issue, and gives a false sense on compliance. Setting to critical.

#16 Updated by Benoît PECCATTE 10 days ago

my algorithm is still valid

#17 Updated by Vincent MEMBRÉ 8 days ago

  • Target version changed from 4.1.12 to 4.1.13

#18 Updated by Benoît PECCATTE 5 days ago

  • Target version changed from 4.1.13 to 411

#19 Updated by Benoît PECCATTE 5 days ago

  • Target version changed from 411 to 4.1.13

#20 Updated by François ARMAND 4 days ago

  • Related to Bug #12643: Compliance bar appears partially white in some graphes added

Also available in: Atom PDF