Project

General

Profile

Bug #10601

If component value starts with # , report is not outputed by rudder agent output

Added by Nicolas CHARLES 8 months ago. Updated 5 months ago.

Status:
Released
Priority:
N/A
Category:
Agent
Target version:
Target version (plugin):
Severity:
Critical - prevents main use of Rudder | no workaround | data loss | security
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Small
Priority:
67

Description

If a component value starts with #, the output is not correctly parsed by command rudder agent
Example:

R: @@sshKeyDistribution@@result_success@@uuid@@uuid@@SSH key@@# my key@@2017-04-13 12:31:32+00:00##uuid@#SSH key "# my key" for user was correct

it conflict with the last @#


Related issues

Related to Rudder - Bug #8862: Broken agent parsing when some report data start or ends with a separator char New
Related to Rudder - Architecture #10648: Use the same regex as rsyslog to parse Rudder reports New

Associated revisions

Revision 53d34a94
Added by Alexis MOUSSET 7 months ago

Fixes #10601: If component value starts with # , report is not outputed by rudder agent output

Revision 5eeeeefc
Added by Vincent MEMBRÉ 7 months ago

Revert "Fixes #10601: If component value starts with # , report is not outputed by rudder agent output"

This reverts commit 53d34a94ecb9cb2007105a5deddec740425c4f2a.

Revision 82f99d4f
Added by Vincent MEMBRÉ 6 months ago

Revert "Fixes #10601: If component value starts with # , report is not outputed by rudder agent output"

This reverts commit 53d34a94ecb9cb2007105a5deddec740425c4f2a.

Revision 3326d01f
Added by Benoît PECCATTE 5 months ago

Fixes #10601: If component value starts with # , report is not outputed by rudder agent output

History

#1 Updated by Alexis MOUSSET 8 months ago

  • Related to Bug #8862: Broken agent parsing when some report data start or ends with a separator char added

#2 Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 3.1.19 to 3.1.20

#3 Updated by François ARMAND 7 months ago

  • Priority changed from 0 to 60

#4 Updated by Jonathan CLARKE 7 months ago

  • Assignee deleted (Alexis MOUSSET)

#5 Updated by Alexis MOUSSET 7 months ago

  • Effort required set to Small
  • Priority changed from 60 to 68

We can try to make a second split instead og change the whole parsing.

#6 Updated by Alexis MOUSSET 7 months ago

  • Status changed from New to In progress
  • Assignee set to Alexis MOUSSET

#7 Updated by Alexis MOUSSET 7 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis MOUSSET to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-agent/pull/113

#8 Updated by Alexis MOUSSET 7 months ago

#9 Updated by Alexis MOUSSET 7 months ago

  • Status changed from Pending technical review to Pending release

#10 Updated by Vincent MEMBRÉ 7 months ago

  • Status changed from Pending release to New

#11 Updated by Nicolas CHARLES 6 months ago

This was not correctly reverted !
In 4.1 nightly:

BEGIN {
  FS = "[^@]@#";

#12 Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 3.1.20 to 3.1.21

#13 Updated by Vincent MEMBRÉ 6 months ago

Thiw was revert in 4.0 and 4.1 here : rudder-agent|82f99d4f

#14 Updated by Benoît PECCATTE 6 months ago

  • Target version changed from 3.1.21 to 4.0.7

Let's fix this in 4.0 first

#15 Updated by Benoît PECCATTE 6 months ago

  • Status changed from New to In progress

#16 Updated by Benoît PECCATTE 6 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Alexis MOUSSET
  • Pull Request changed from https://github.com/Normation/rudder-agent/pull/113 to https://github.com/Normation/rudder-agent/pull/116

#17 Updated by Benoît PECCATTE 5 months ago

  • Priority changed from 68 to 67

#18 Updated by Benoît PECCATTE 5 months ago

  • Status changed from Pending technical review to Pending release

#19 Updated by Alexis MOUSSET 5 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.0.7 which was released today.

Also available in: Atom PDF