https://issues.rudder.io/https://issues.rudder.io/themes/rudder7/favicon/favicon.ico?17096450182017-04-07T09:28:33ZIssue TrackerRudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valuehttps://issues.rudder.io/issues/10570?journal_id=747052017-04-07T09:28:33ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Severity</strong> set to <i>Critical - prevents main use of Rudder | no workaround | data loss | security</i></li><li><strong>User visibility</strong> set to <i>Getting started - demo | first install | level 1 Techniques</i></li><li><strong>Effort required</strong> set to <i>Small</i></li></ul><p>I'm setting criticity to "critical", because it means that people using that feature and migrating to 4.1 may encounter data loss (dyn group can be broken).</p> Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valuehttps://issues.rudder.io/issues/10570?journal_id=747062017-04-07T09:40:03ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In progress</i></li><li><strong>Assignee</strong> set to <i>Vincent MEMBRÉ</i></li></ul> Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valuehttps://issues.rudder.io/issues/10570?journal_id=747152017-04-07T12:53:29ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Severity</strong> changed from <i>Critical - prevents main use of Rudder | no workaround | data loss | security</i> to <i>Major - prevents use of part of Rudder | no simple workaround</i></li></ul><p>Ok, so in fact, it is not a regression. We just have more luck in the environment, and so it won't break existing things (it's just that the problem is not raised when nodes don't have properties). I'm decreasing the severity to major, because it "just" make some part of Rudder not usable.</p> Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valuehttps://issues.rudder.io/issues/10570?journal_id=747162017-04-07T13:49:37ZVincent MEMBRÉvme@rudder.io
<ul></ul><p>More explanation.</p>
<p>A value in a 'name=value' field (here Node properties, but it's the same for environment variable) needs an = to make a difference between name and value.</p>
<p>If you enter a value without "=" in a regex query, it fails to split the value and it should fail. But we ignore the error and replace by ".*.*"</p>
<p>Which matches any property and so every Node with a property is a valid result... Which is clearly not what we want</p>
<p>Which should make an error when the data is not valid</p> Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valuehttps://issues.rudder.io/issues/10570?journal_id=747172017-04-07T13:49:48ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Target version</strong> changed from <i>4.1.1</i> to <i>3.1.19</i></li></ul> Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valuehttps://issues.rudder.io/issues/10570?journal_id=747202017-04-07T16:21:11ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>In progress</i> to <i>Pending technical review</i></li><li><strong>Assignee</strong> changed from <i>Vincent MEMBRÉ</i> to <i>François ARMAND</i></li><li><strong>Pull Request</strong> set to <i>https://github.com/Normation/rudder/pull/1626</i></li></ul><p>PR <a class="external" href="https://github.com/Normation/rudder/pull/1626">https://github.com/Normation/rudder/pull/1626</a></p> Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valuehttps://issues.rudder.io/issues/10570?journal_id=747212017-04-07T16:22:18ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Subject</strong> changed from <i>Regex search on node properties is broken: returns all node</i> to <i>Regex search on node properties is broken: returns all nodes with a property when no using invalid value</i></li></ul> Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valuehttps://issues.rudder.io/issues/10570?journal_id=747852017-04-12T12:24:34ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Pending release</i></li></ul><p>Applied in changeset <a class="changeset" title="Fixes #10570: Regex search on node properties is broken: returns all nodes with a property when n..." href="https://issues.rudder.io/projects/rudder/repository/rudder/revisions/1b4b8ea885f1fb1153b2a6861bf6a9d358f951eb">rudder|1b4b8ea885f1fb1153b2a6861bf6a9d358f951eb</a>.</p> Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valuehttps://issues.rudder.io/issues/10570?journal_id=753362017-04-19T10:12:17ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending release</i> to <i>Released</i></li></ul><p>This bug has been fixed in Rudder 3.1.19, 4.0.4 and 4.1.1 which were released today.</p>
<ul>
<li>3.1.19: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2017-April/thread.html000227.html" class="external">Announce</a> <a href="http://www.rudder-project.org/changelog-3.1#3.1.19" class="external">Changelog</a></li>
<li>4.0.4: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2017-April/thread.html000226.html" class="external">Announce</a> <a href="http://www.rudder-project.org/changelog-4.0#4.0.4" class="external">Changelog</a></li>
<li>4.1.1: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2017-April/thread.html000228.html" class="external">Announce</a> <a href="http://www.rudder-project.org/changelog-4.1#4.1.1" class="external">Changelog</a></li>
<li>Download: <a class="external" href="https://www.rudder-project.org/site/get-rudder/downloads/">https://www.rudder-project.org/site/get-rudder/downloads/</a></li>
</ul> Rudder - Bug #10570: Regex search on node properties is broken: returns all nodes with a property when no using invalid valuehttps://issues.rudder.io/issues/10570?journal_id=755032017-04-20T16:39:28ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-16 priority-default closed parent" href="/issues/10599">Bug #10599</a>: Impossible to search or build groups based on JSON values in node properties</i> added</li></ul>