Project

General

Profile

User story #10412

Add a convention for ".disabled" hooks to not be executed

Added by François ARMAND 6 months ago. Updated 6 months ago.

Status:
Released
Priority:
N/A
Category:
-
Target version:
Target version (plugin):
Suggestion strength:
User visibility:
Effort required:

Description

In #8353, we added hooks. It was decided at the time that we will choose which scripts to execute based on the exec bit of the file. It means that to disable a script, you "set -x" it.

Now, there is a commonly used convention that in that kind of context, a ".disabled" script will not be executed even if it is set +x.

To be more general, it should be a list of excluded extension, which could also takes care of "rpmnew" and other things.

The documentation will need to be updated accordingly.

The list of suffixes that will make a hook be ignored is defined in /opt/rudder/etc/rudder-web.properties => rudder.hooks.ignore-suffixes


Subtasks

User story #10425: Add migration script for hooks ignore suffixesReleasedVincent MEMBRÉ


Related issues

Related to Rudder - Bug #10379: When upgrading to 4.1, rudder.community.checkpromises.command=/bin/true option is lost Released

Associated revisions

Revision 1b3ff90e
Added by François ARMAND 6 months ago

Fixes #10412: Add a convention for \".disabled\" hooks to not be executed

History

#1 Updated by François ARMAND 6 months ago

  • Description updated (diff)

#2 Updated by François ARMAND 6 months ago

  • Related to Bug #10379: When upgrading to 4.1, rudder.community.checkpromises.command=/bin/true option is lost added

#3 Updated by François ARMAND 6 months ago

  • Target version set to 4.1.0

#4 Updated by François ARMAND 6 months ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND

#5 Updated by François ARMAND 6 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1592

#6 Updated by François ARMAND 6 months ago

  • Description updated (diff)

#7 Updated by François ARMAND 6 months ago

  • Status changed from Pending technical review to Pending release

#8 Updated by Benoît PECCATTE 6 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.0 which was released today.

Also available in: Atom PDF