Project

General

Profile

Actions

User story #10368

closed

Add expires on static content ncf builder

Added by Alexis Mousset about 7 years ago. Updated almost 3 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
-
Category:
Packaging
UX impact:
Suggestion strength:
Advise - This would make Rudder significantly better | easier | simpler
User visibility:
Effort required:
Medium
Name check:
Fix check:
Regression:

Description

Add expires on static content of the builder.


Related issues 1 (0 open1 closed)

Related to Rudder - User story #10366: Add expiration on static resourcesRejectedBenoît PECCATTEActions
Actions #1

Updated by Alexis Mousset about 7 years ago

  • Status changed from New to In progress
  • Assignee set to Alexis Mousset
Actions #2

Updated by Alexis Mousset about 7 years ago

  • Project changed from 41 to Rudder
  • Category changed from Packaging to Packaging
  • Status changed from In progress to New
  • Target version changed from 1.0 to 4.1.0
Actions #3

Updated by Alexis Mousset about 7 years ago

  • Status changed from New to In progress
Actions #4

Updated by Alexis Mousset about 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Alexis Mousset to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1284
Actions #5

Updated by François ARMAND about 7 years ago

Actions #6

Updated by Alexis Mousset about 7 years ago

  • Status changed from Pending technical review to New

We would need to add a version parameter in URLs of the index.html to avoid trouble.

Actions #7

Updated by Alexis Mousset about 7 years ago

  • Subject changed from Add expires on static content in apache conf to Add expires on static content ncf builder
  • Assignee deleted (Benoît PECCATTE)
  • Target version deleted (4.1.0)
Actions #8

Updated by Alexis Mousset about 7 years ago

  • Suggestion strength set to Advise - This would make Rudder significantly better | easier | simpler
  • Effort required set to Medium
  • Pull Request deleted (https://github.com/Normation/rudder-packages/pull/1284)
Actions #9

Updated by François ARMAND about 7 years ago

I believe they have a cache version, or I'm missing something?

In /rudder/index.html (login page):

...
    <link href="/rudder/cache-4.1.0~rc2-SNAPSHOT/images/rudder-favicon.ico" type="image/x-icon" rel="icon">
    <script src="/rudder/cache-4.1.0~rc2-SNAPSHOT/javascript/jquery/jquery-3.1.0.min.js" type="text/javascript"></script>
...
    <img src="/rudder/cache-4.1.0~rc2-SNAPSHOT/images/login/logo-rudder.svg" alt="Rudder">

And in rudder/secure/index.html

...
    <link href="/rudder/cache-4.1.0~rc2-SNAPSHOT/style/rudder/rudder-menu.css" rel="stylesheet" type="text/css">
    <script src="/rudder/cache-4.1.0~rc2-SNAPSHOT/javascript/utils/WeakMap.js" type="text/javascript"></script>
...

And in all cases, only the path with the cache version get the cache headers.

Actions #10

Updated by Alexis Mousset about 7 years ago

This ticket is about ncf-builder, I don't think it currently have a version number in URLs

Actions #11

Updated by François ARMAND about 7 years ago

OH sorry, of course!

Actions #12

Updated by Benoît PECCATTE about 6 years ago

  • Target version set to Ideas (not version specific)
Actions #13

Updated by Alexis Mousset almost 3 years ago

  • Status changed from New to Rejected

No more separate ncf-builder

Actions

Also available in: Atom PDF