Project

General

Profile

Actions
Copy link

Bug #10304

closed

Broken variable expression when using node properties in the technique editor

Added by Avit Sidis about 7 years ago. Updated about 6 years ago.

Status:
Released
Priority:
N/A
Assignee:
Benoît PECCATTE
Category:
Web - Technique editor
Target version:
4.1.10
Pull Request:
https://github.com/Normation/ncf/pull...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Small
Priority:
56
Name check:
Fix check:
Regression:

Description

Whenever we use a node property in the technique editor inside a method like command, result classes contain a broken variable expression. Once we execute generated directive we encounter this error message:
error: Broken variable expression, index brackets do not balance, in 'node.properties[ENV_'

Related issues 2 (0 open — 2 closed)

Related to Rudder - Bug #8586: Wrong definition of class condition if we use a variable with [ ] in itRejectedActions
Related to Rudder - Bug #11600: Result class containing {} are not properly canonizedReleasedBenoît PECCATTEActions
Actions
Copy link
 #1

Updated by Benoît PECCATTE about 7 years ago

  • Category set to Web - Technique editor
Actions
Copy link
 #2

Updated by François ARMAND about 7 years ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
Actions
Copy link
 #3

Updated by Benoît PECCATTE about 7 years ago

  • Priority set to 36
Actions
Copy link
 #4

Updated by Nicolas CHARLES almost 7 years ago

  • Effort required set to Small
  • Priority changed from 36 to 44

effort seems quite small, it's only the regex

regex = re.compile("[^\$\{\}a-zA-Z0-9_](?![^{}]+})|\$(?!{)")

in tools/ncf_rudder.py to change

someone competend in regex could fix it pretty easily

Actions
Copy link
 #5

Updated by Nicolas CHARLES almost 7 years ago

  • Related to Bug #8586: Wrong definition of class condition if we use a variable with [ ] in it added
Actions
Copy link
 #6

Updated by Benoît PECCATTE almost 7 years ago

  • Priority changed from 44 to 53
Actions
Copy link
 #7

Updated by Nicolas CHARLES over 6 years ago

  • Related to Bug #11600: Result class containing {} are not properly canonized added
Actions
Copy link
 #8

Updated by Benoît PECCATTE over 6 years ago

  • Priority changed from 53 to 60
Actions
Copy link
 #9

Updated by Benoît PECCATTE about 6 years ago

  • Target version set to 4.1.10
  • Priority changed from 60 to 57
Actions
Copy link
 #10

Updated by Benoît PECCATTE about 6 years ago

  • Status changed from New to In progress
  • Assignee set to Benoît PECCATTE
Actions
Copy link
 #11

Updated by Benoît PECCATTE about 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/ncf/pull/696
Actions
Copy link
 #12

Updated by Rudder Quality Assistant about 6 years ago

  • Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
Actions
Copy link
 #13

Updated by Benoît PECCATTE about 6 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset ncf:commit:4ec79bb68c0b9e58be83a1a35d2d26a8d69d910a.

Actions
Copy link
 #14

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
  • Priority changed from 57 to 56

This bug has been fixed in Rudder 4.1.10 and 4.2.4 which were released today.

Actions
Copy link

Also available in: Atom PDF