https://issues.rudder.io/https://issues.rudder.io/themes/rudder7/favicon/favicon.ico?17096450182017-02-17T09:12:33ZIssue TrackerRudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=707472017-02-17T09:12:33ZDmitry Svyatogorov
<ul></ul><ul>
<li>* API "Create a new Directive" is broken as well. Just create some directive in current beta, then try to get/put it. Server answers with <strong>plain text</strong> "Could not extract values from request." <br />Example json to PUT:<br /><pre>
{"policyMode": "default", "displayName": "/test", "parameters": {"section": {"sections": [{"section": {"sections": [{"section": {"name": "Enforce content by section", "vars": [{"var": {"name": "GENERIC_FILE_CONTENT_SECTION_MANAGEMENT", "value": "false"}}, {"var": {"name": "GENERIC_FILE_SECTION_CONTENT", "value": ""}}, {"var": {"name": "GENERIC_FILE_SECTION_FOOTER", "value": ""}}, {"var": {"name": "GENERIC_FILE_SECTION_HEADER", "value": ""}}]}}, {"section": {"name": "Enforce content only in zone", "vars": [{"var": {"name": "GENERIC_FILE_CONTENT_MIGRATE_TO_ZONE_BOOLEAN", "value": "false"}}, {"var": {"name": "GENERIC_FILE_CONTENT_ZONE_FOOTER", "value": "### End of section managed by Rudder"}}, {"var": {"name": "GENERIC_FILE_CONTENT_ZONE_HEADER", "value": "### Beginning of section managed by Rudder"}}]}}, {"section": {"name": "File", "vars": [{"var": {"name": "GENERIC_FILE_CONTENT_CREATE_BOOLEAN", "value": "true"}}, {"var": {"name": "GENERIC_FILE_CONTENT_DELETION_BOOLEAN", "value": "false"}}, {"var": {"name": "GENERIC_FILE_CONTENT_ENFORCE", "value": "true"}}, {"var": {"name": "GENERIC_FILE_CONTENT_ENFORCE_CREATE_ONLY_BOOLEAN", "value": "false"}}, {"var": {"name": "GENERIC_FILE_CONTENT_MODIFICATION_BOOLEAN", "value": "false"}}, {"var": {"name": "GENERIC_FILE_CONTENT_ONLY_ZONE_BOOLEAN", "value": "false"}}, {"var": {"name": "GENERIC_FILE_CONTENT_PATH", "value": "/test"}}]}}, {"section": {"name": "File content", "vars": [{"var": {"name": "GENERIC_FILE_CONTENT_PAYLOAD", "value": "test"}}]}}, {"section": {"name": "Line deletion regular expressions", "vars": [{"var": {"name": "GENERIC_FILE_CONTENT_DELETION_REGEXP", "value": "deleteme.*"}}]}}, {"section": {"name": "Line replacement regular expressions", "vars": [{"var": {"name": "GENERIC_FILE_CONTENT_MODIFICATION_DESTINATION", "value": ""}}, {"var": {"name": "GENERIC_FILE_CONTENT_MODIFICATION_REGEXP", "value": "replaceme.*"}}]}}, {"section": {"name": "Permission adjustment", "vars": [{"var": {"name": "GENERIC_FILE_CONTENT_GROUP", "value": "root"}}, {"var": {"name": "GENERIC_FILE_CONTENT_OWNER", "value": "root"}}, {"var": {"name": "GENERIC_FILE_CONTENT_PERM", "value": "644"}}, {"var": {"name": "GENERIC_FILE_CONTENT_PERMISSION_ADJUSTMENT", "value": "true"}}]}}, {"section": {"name": "Post-modification hook", "vars": [{"var": {"name": "GENERIC_FILE_CONTENT_POST_HOOK_COMMAND", "value": ""}}, {"var": {"name": "GENERIC_FILE_CONTENT_POST_HOOK_RUN", "value": "false"}}]}}], "name": "File to manage"}}], "name": "sections"}}, "tags": [{"a": "b"}], "enabled": true, "system": false, "longDescription": "", "priority": 5, "techniqueName": "checkGenericFileContent", "shortDescription": "", "id": "ae1af95a-62ed-44be-983d-eacf42a12f9d"}
</pre></li>
</ul> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=707502017-02-17T09:23:42ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Priority</strong> changed from <i>N/A</i> to <i>1</i></li></ul><p>Hello Dmitry !</p>
<p>Thank you for reporting this. We haven't changed anything but we changed some of our dependencies (especially one manipulating json / rest api ) maybe a behavior changed</p>
<p>I'll fix it asap</p> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=707512017-02-17T09:25:44ZVincent MEMBRÉvme@rudder.io
<ul></ul><p>May be some code to extract data changed too</p> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=715522017-02-22T11:47:05ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In progress</i></li><li><strong>Assignee</strong> set to <i>Vincent MEMBRÉ</i></li></ul> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=715582017-02-22T12:50:41ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Target version</strong> changed from <i>4.1.0~rc1</i> to <i>3.1.19</i></li></ul> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=715802017-02-22T14:47:36ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>In progress</i> to <i>Pending technical review</i></li><li><strong>Assignee</strong> changed from <i>Vincent MEMBRÉ</i> to <i>François ARMAND</i></li><li><strong>Pull Request</strong> set to <i>https://github.com/Normation/rudder/pull/1523</i></li></ul><p>PR <a class="external" href="https://github.com/Normation/rudder/pull/1523">https://github.com/Normation/rudder/pull/1523</a></p> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=715852017-02-22T15:30:14ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Subject</strong> changed from <i>API "Create a new Group" is broken in Rudder 4.1.0 beta 3</i> to <i>Fix behavior of directive API and make api more consistent</i></li><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>In progress</i></li><li><strong>Assignee</strong> changed from <i>François ARMAND</i> to <i>Vincent MEMBRÉ</i></li><li><strong>Pull Request</strong> deleted (<del><i>https://github.com/Normation/rudder/pull/1523</i></del>)</li></ul><p>After some inquiry, I found two issues:</p>
<ul>
<li>The library we use to parse json has changed a behavior, breaking both Directives and Groups Rest API, changing the function used fix the issue</li>
<li>"displayName" is not parsed correctly and is ignored a workaround is to use "name" instead, but we need to fix the parsing of "displayName"</li>
</ul>
<p>Backporting the fix to 3.1</p> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=715952017-02-22T16:37:55ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>In progress</i> to <i>Pending technical review</i></li><li><strong>Assignee</strong> changed from <i>Vincent MEMBRÉ</i> to <i>François ARMAND</i></li><li><strong>Pull Request</strong> set to <i>https://github.com/Normation/rudder/pull/1523</i></li></ul> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=716702017-02-23T10:12:53ZBenoît PECCATTEbenoit.peccatte@rudder.io
<ul><li><strong>Found in version (s)</strong> <i>4.1.0~beta2</i> added</li></ul> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=717132017-02-23T10:14:46ZBenoît PECCATTEbenoit.peccatte@rudder.io
<ul><li><strong>Found in version(s) old</strong> deleted (<del><i>4.1.0.beta2</i></del>)</li></ul> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=717802017-02-24T11:11:13ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Pending release</i></li></ul><p>Applied in changeset <a class="changeset" title="Fixes #10225: API "Create a new Group" is broken in Rudder 4.1.0 beta 3" href="https://issues.rudder.io/projects/rudder/repository/rudder/revisions/d4b404c584737b3e9c84e5f37e864e7e19f7135e">rudder|d4b404c584737b3e9c84e5f37e864e7e19f7135e</a>.</p> Rudder - Bug #10225: Fix behavior of directive API and make api more consistenthttps://issues.rudder.io/issues/10225?journal_id=753692017-04-19T10:12:47ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending release</i> to <i>Released</i></li><li><strong>Priority</strong> set to <i>0</i></li></ul><p>This bug has been fixed in Rudder 3.1.19, 4.0.4 and 4.1.1 which were released today.</p>
<ul>
<li>3.1.19: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2017-April/thread.html000227.html" class="external">Announce</a> <a href="http://www.rudder-project.org/changelog-3.1#3.1.19" class="external">Changelog</a></li>
<li>4.0.4: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2017-April/thread.html000226.html" class="external">Announce</a> <a href="http://www.rudder-project.org/changelog-4.0#4.0.4" class="external">Changelog</a></li>
<li>4.1.1: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2017-April/thread.html000228.html" class="external">Announce</a> <a href="http://www.rudder-project.org/changelog-4.1#4.1.1" class="external">Changelog</a></li>
<li>Download: <a class="external" href="https://www.rudder-project.org/site/get-rudder/downloads/">https://www.rudder-project.org/site/get-rudder/downloads/</a></li>
</ul>