Project

General

Profile

Bug #10198

EventLog at promise generation for datasources change, even if nothing changed

Added by Nicolas CHARLES 7 months ago. Updated 7 months ago.

Status:
Released
Priority:
N/A
Category:
Plugin - datasources
Target version:
Target version (plugin):
Severity:
User visibility:
Effort required:
Priority:

Description

At each promise generation, I get "Node modified" eventlogs, even if nothing was changed, due to datasource.
Raw technical detail is:

            <entry>
  <node fileFormat="6" changeType="modify">
    <id>82d806d8-1359-4d8f-a405-fe8cab062888</id>
    <properties>
      <from>
        <property>
          <name>Test_datasource</name>
          <value>JString(78.249.200.184)</value>
        </property>
        <property>
          <name>Pouet</name>
          <value>
            JObject(List(JField(args,JObject(List())), JField(headers,JObject(List(JField(Accept,JString(text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2)), JField(Accept-Encoding,JString(gzip,deflate)), JField(Host,JString(httpbin.org)), JField(User-Agent,JString(scalaj-http/1.0))))), JField(origin,JString(78.249.200.184)), JField(url,JString(https://httpbin.org/get))))
          </value>
        </property>
      </from>
      <to>
        <property>
          <name>Test_datasource</name>
          <value>JString(78.249.200.184)</value>
        </property>
        <property>
          <name>Pouet</name>
          <value>
            JObject(List(JField(args,JObject(List())), JField(headers,JObject(List(JField(Accept,JString(text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2)), JField(Accept-Encoding,JString(gzip,deflate)), JField(Host,JString(httpbin.org)), JField(User-Agent,JString(scalaj-http/1.0))))), JField(origin,JString(78.249.200.184)), JField(url,JString(https://httpbin.org/get))))
          </value>
        </property>
      </to>
    </properties>
  </node>
</entry>

I suspect that deserialization is not correctly done, and comparision is invalid

Associated revisions

Revision a951e411
Added by François ARMAND 7 months ago

Fixes #10198: EventLog at promise generation for datasources change, even if nothing changed

History

#1 Updated by François ARMAND 7 months ago

  • Assignee set to François ARMAND

#2 Updated by François ARMAND 7 months ago

  • Status changed from New to In progress

#3 Updated by François ARMAND 7 months ago

  • Target version changed from 4.1.0~rc1 to 4.0.3

It is in fact a problem with the underlying repos which save event in all case since 4.0, even when not modification are done.

#4 Updated by François ARMAND 7 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1500

#5 Updated by François ARMAND 7 months ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

#6 Updated by Vincent MEMBRÉ 7 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.0.3 and 4.1.0~beta3 which were released today.

Also available in: Atom PDF