Architecture #9440
closed
Directives are not correctly grouped in nodeconfiguration table
Description
The configuration json contains:
,{ +
| | | | "directiveId":"common-root", +
| | | | "isSystem":true, +
| | | | "components":[{ +
| | | | "componentName":"Log system for reports", +
| | | | "cardinality":1, +
| | | | "values":["None"], +
| | | | "unexpanded":["None"] +
| | | | }] +
| | | | },{ +
| | | | "directiveId":"common-root", +
| | | | "isSystem":true, +
| | | | "components":[{ +
| | | | "componentName":"CRON Daemon", +
| | | | "cardinality":1, +
| | | | "values":["None"], +
| | | | "unexpanded":["None"] +
| | | | }] +
| | | | },{ +
| | | | "directiveId":"common-root", +
| | | | "isSystem":true, +
| | | | "components":[{ +
| | | | "componentName":"Binaries update", +
| | | | "cardinality":1, +
| | | | "values":["None"], +
| | | | "unexpanded":["None"] +
| | | | }]
but i expected all components to be inthe same directive
Updated by François ARMAND over 7 years ago
- Status changed from New to In progress
Updated by François ARMAND over 7 years ago
In fact the problem is that the source object has several time the same directive. There is a missing "group by" somewhere, and the invariant about that grouping is not enforced.
But on the other hand, that is not really a problem per se, because having several time the same directive is not necessary anywhere (but it is not what is expected by user, like see here).
I can do several things, not sure about the correct one right now:
- enforce at serialisation time that things are correctly grouped together
- enforce in our model that each stage is grouped by the identicator of the stage (ruleId, directiveId, componentName, componentValue). We also loose the hability the order rules/directives/etc. I believe this is ok.
It seems "better", but significantly complexify the domain model.
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 318 to 4.0.0~rc2
Updated by François ARMAND over 7 years ago
- Target version changed from 4.0.0~rc2 to 321
Updated by Alexis Mousset over 7 years ago
- Target version changed from 321 to 4.0.1
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 4.0.1 to 4.0.2
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 4.0.2 to 4.0.3
Updated by Alexis Mousset about 7 years ago
- Translation missing: en.field_tag_list deleted (
Blocking 4.0)
This is not blocking.
Updated by Vincent MEMBRÉ about 7 years ago
- Target version changed from 4.0.3 to 4.0.4
Updated by François ARMAND about 7 years ago
- Tracker changed from Bug to Architecture
- Status changed from In progress to New
- Assignee deleted (
François ARMAND)
Updated by Vincent MEMBRÉ about 7 years ago
- Target version changed from 4.0.4 to 4.0.5
Updated by Vincent MEMBRÉ almost 7 years ago
- Target version changed from 4.0.5 to 4.0.6
Updated by Vincent MEMBRÉ almost 7 years ago
- Target version changed from 4.0.6 to 4.0.7
Updated by Vincent MEMBRÉ almost 7 years ago
- Target version changed from 4.0.7 to 357
Updated by Alexis Mousset almost 7 years ago
- Target version changed from 357 to 4.1.6
Updated by Vincent MEMBRÉ over 6 years ago
- Target version changed from 4.1.6 to 4.1.7
Updated by Vincent MEMBRÉ over 6 years ago
- Target version changed from 4.1.7 to 4.1.8
Updated by Vincent MEMBRÉ over 6 years ago
- Target version changed from 4.1.8 to 4.1.9
Updated by Vincent MEMBRÉ over 6 years ago
- Target version changed from 4.1.9 to 4.1.10
Updated by Benoît PECCATTE about 6 years ago
- Target version changed from 4.1.10 to Ideas (not version specific)
Updated by Nicolas CHARLES almost 4 years ago
- Status changed from New to Rejected
this has been solved in the past
nodeconfigurations are a bit more compact now, in this respect