Project

General

Profile

Actions

Architecture #9202

closed

Clean old fileFormat migration and fileFormat numbering policy

Added by François ARMAND over 7 years ago. Updated over 7 years ago.

Status:
Released
Priority:
2
Category:
Architecture - Code maintenance
Target version:
Effort required:
Name check:
Fix check:
Regression:

Description

We have a lot of old migration that are kept so that old archives can still be read.

We want to only support archive from up to the last LTS, even more now that we have a more or less stable file format.

For example, for 4.0, we want to support only fileFormat of 3.1 and newer, i.e fileFormat=6 and more recent.

We also want to update the rule for file format number bump:

- if we only add new items, or new fields, and these fields are optionnal or a reasonnable default can be provided if they are missing, we DON'T change the fileFormat number,
- we only bump fileFormat in the case of a breaking change, non sortable locally or too higly costly to support either in maintenance cost or performance. Such a case would the renaiming of a lot of business object, or the addition of a new complex, costly I/O field. Changing events from one type to an other is another use case.

With that, we can keep only fileFormat 6 in Rudder.

I propose to keep the migration scheme from fileFormat=5, so it allows to read archive from Rudder 2.10/2.11, which is quite old and let us be sure we won't make user unhappy while keeping the migration logic (which works great, now).


Related issues 5 (0 open5 closed)

Related to Rudder - User story #9204: Clean up unused NodeXXXModified eventsReleasedVincent MEMBRÉ2016-10-03Actions
Related to Rudder - Bug #6001: Change request are not migrated to fileformat 6ReleasedNicolas CHARLES2014-12-15Actions
Related to Rudder - Bug #4351: Importing old archive is not working (fileformat < 5)ReleasedFrançois ARMAND2014-01-13Actions
Related to Rudder - User story #8125: Make eventlog migration faster (parallilised)Rejected2016-03-31Actions
Has duplicate Rudder - Architecture #7574: Remove event log migration less than 5->6RejectedFrançois ARMANDActions
Actions #1

Updated by François ARMAND over 7 years ago

  • Description updated (diff)
Actions #2

Updated by François ARMAND over 7 years ago

Actions #3

Updated by François ARMAND over 7 years ago

  • Category set to Architecture - Code maintenance
  • Assignee set to François ARMAND
  • Priority changed from N/A to 2
  • Target version set to 4.0.0~rc2
Actions #4

Updated by François ARMAND over 7 years ago

  • Status changed from New to In progress
Actions #5

Updated by François ARMAND over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1234
Actions #6

Updated by François ARMAND over 7 years ago

  • Related to Bug #6001: Change request are not migrated to fileformat 6 added
Actions #7

Updated by François ARMAND over 7 years ago

  • Related to Bug #4351: Importing old archive is not working (fileformat < 5) added
Actions #8

Updated by François ARMAND over 7 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #9

Updated by Benoît PECCATTE over 7 years ago

  • Target version changed from 4.0.0~rc2 to 318
Actions #10

Updated by François ARMAND over 7 years ago

  • Related to User story #8125: Make eventlog migration faster (parallilised) added
Actions #11

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 318 to 4.0.0~rc2
Actions #12

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.0.0~rc2 to 4.0.0~rc1
Actions #13

Updated by Alexis Mousset over 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.0.0 which was released the 10th November 2016.

Actions #14

Updated by François ARMAND about 7 years ago

Actions

Also available in: Atom PDF