Bug #9001: [rudder-packages] invalid spec files for SLES12 SP1 - Rudder - Issue Tracker

Actions

Copy link

Bug #9001

closed

[rudder-packages] invalid spec files for SLES12 SP1

Added by Janos Mattyasovszky over 7 years ago. Updated over 7 years ago.

Status:

Released

Priority:

N/A

Assignee:

Benoît PECCATTE

Category:

Packaging

Target version:

3.1.14

Pull Request:

https://github.com/Normation/rudder-p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

As of SLES12 SP1 (presumably), the SPEC File's %{sles_version} is obsoleted in favor of the all-present %{suse_release}.
Since the macro is only used to determine if it's SLES or not, and not to determine anything version-related, replacing it will not cause any issues.

- %if 0%{?sles_version}
+ %if 0%{?suse_version}

Actions

Copy link

Updated by Benoît PECCATTE over 7 years ago

is %{suse_release} available in sles 11 and sles 10 ?

Actions

Copy link

Updated by Matthieu CERDA over 7 years ago

Well, according to "rpm --showrc", at least on SLES 11 there is no suse_release

Actions

Copy link

Updated by Janos Mattyasovszky over 7 years ago

Try rpm --eval '%{suse_version}':

SLES12 SP1:

# rpm --eval '%{sles_version} %{suse_version}'
0 1315

SLES11 SP1:

# rpm --eval '%{sles_version} %{suse_version}'
11 1110

SLES10 SP2:

# rpm --eval '%{sles_version} %{suse_version}'
10 1010

According to this site, it is defined since SLES 9

SUSE Linux 10.1     %if 0%{?suse_version} == 1010    could also be SLE10*
SUSE Linux 10.0     %if 0%{?suse_version} == 1000    
SUSE Linux 9.3     %if 0%{?suse_version} == 930
SLES 9     %if 0%{?suse_version} == 910
SLE 10     %if 0%{?suse_version} == 1010
SLE 11     %if 0%{?suse_version} == 1110
SLE 12     %if 0%{?suse_version} == 1315    could also be Leap 42.1*

Actions

Copy link

Updated by Janos Mattyasovszky over 7 years ago

Description updated (diff)

Actions

Copy link

Updated by Janos Mattyasovszky over 7 years ago

Pull Request set to https://github.com/Normation/rudder-packages/pull/1043

Actions

Copy link

Updated by Janos Mattyasovszky over 7 years ago

Subject changed from [rudder-packages] Webapp has invalid spec file on SLES12 SP1 to [rudder-packages] invalid spec files for SLES12 SP1

Actions

Copy link

Updated by Jonathan CLARKE over 7 years ago

Status changed from New to Pending technical review

A pull request has been added to this ticket, so it's status should be "Pending technical review" to ensure both coherance and that it gets the attention needed.

Actions

Copy link

Updated by Jonathan CLARKE over 7 years ago

Target version set to 4.0.0~rc2

A target version should always be present if a Pull Request is too - this enables the changelog to be built correctly.

Actions

Copy link

Updated by Benoît PECCATTE over 7 years ago

Status changed from Pending technical review to In progress
Assignee set to Benoît PECCATTE

I'm taking over this ticket!

Actions

Copy link

#10

Updated by Benoît PECCATTE over 7 years ago

Target version changed from 4.0.0~rc2 to 3.1.14

Actions

Copy link

#11

Updated by Benoît PECCATTE over 7 years ago

I'm taking over this ticket!

Actions

Copy link

#12

Updated by Benoît PECCATTE over 7 years ago

Status changed from In progress to Pending technical review
Pull Request changed from https://github.com/Normation/rudder-packages/pull/1043 to https://github.com/Normation/rudder-packages/pull/1080

PR https://github.com/Normation/rudder-packages/pull/1080

Actions

Copy link

#13