Project

General

Profile

Actions
Copy link

Architecture #8683

closed

check_* methods output error messages when the result of a check is "no"

Added by Nicolas CHARLES almost 8 years ago. Updated 8 months ago.

Status:
Resolved
Priority:
N/A
Assignee:
-
Category:
Generic methods
Target version:
8.1.0~alpha1
Pull Request:
Effort required:
Name check:
Fix check:
Regression:

Description

service_ensure_stopped use service_check_running to check is a service is running or not.
service_check_running_ps checks if the service is running, and if it is, it returns a success class, if it is not, it returns an error class

So when the service is stopped (which is the expected status), service_check_running_ps outputs an error message 

R: [ERROR] Promise could not be repaired, error encountered: Check if the service SERVICENAME is started using ps

which is really confusing for a normal person not knowing the internals of ncf

Related issues 3 (0 open — 3 closed)

Is duplicate of Rudder - User story #6368: Methods named check_* should have an equivalent without reportingResolvedActions
Has duplicate Rudder - Bug #8846: broken report from Directory check existsRejectedActions
Has duplicate Rudder - Bug #15080: Service technique reports a warning after stopping a serviceRejectedActions
Actions
Copy link
 #1

Updated by François ARMAND almost 8 years ago

  • Status changed from New to Rejected

This is an architectural problem whose solution is depicted in #6368. I'm closing this one as duplicate, but it is still a good example case.

Actions
Copy link
 #2

Updated by François ARMAND almost 8 years ago

  • Is duplicate of User story #6368: Methods named check_* should have an equivalent without reporting added
Actions
Copy link
 #3

Updated by Jonathan CLARKE over 7 years ago

  • Subject changed from service_ensure_stopped outputs error messages when a service is already stopped to check_* methods output error messages when the result of a check is "no"
  • Status changed from Rejected to New

We should adapt the result classes of check_* methods to define a separate state that indicated "check result is no" rather than "error", and adapt our default_logger to display a more friendly message in this case.

Actions
Copy link
 #4

Updated by Alexis Mousset over 7 years ago

  • Category set to Generic methods
Actions
Copy link
 #5

Updated by Jonathan CLARKE over 7 years ago

  • Has duplicate Bug #8846: broken report from Directory check exists added
Actions
Copy link
 #6

Updated by Benoît PECCATTE about 7 years ago

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
  • Priority set to 15
Actions
Copy link
 #7

Updated by Benoît PECCATTE almost 7 years ago

  • Priority changed from 15 to 14
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 0.x to 3.1.25
  • Priority changed from 14 to 27
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.25 to 387
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 387 to 4.1.10
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.10 to 4.1.11
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.11 to 4.1.12
Actions
Copy link
 #13

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.12 to 4.1.13
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.13 to 4.1.14
Actions
Copy link
 #15

Updated by Benoît PECCATTE over 5 years ago

  • Target version changed from 4.1.14 to 4.1.15
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.15 to 4.1.16
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions
Copy link
 #18

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.17 to 4.1.18
  • Priority changed from 27 to 0
Actions
Copy link
 #19

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.18 to 4.1.19
Actions
Copy link
 #20

Updated by Alexis Mousset about 5 years ago

  • Target version changed from 4.1.19 to 4.1.20
Actions
Copy link
 #21

Updated by François ARMAND about 5 years ago

  • Target version changed from 4.1.20 to 4.1.21
Actions
Copy link
 #22

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 4.1.21 to 4.1.22
Actions
Copy link
 #23

Updated by Benoît PECCATTE almost 5 years ago

  • Target version changed from 4.1.22 to 5.0.10
Actions
Copy link
 #24

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 5.0.10 to 5.0.11
Actions
Copy link
 #25

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 5.0.11 to 5.0.12
Actions
Copy link
 #26

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 5.0.12 to 5.0.13
Actions
Copy link
 #27

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.13 to 5.0.14
Actions
Copy link
 #28

Updated by François ARMAND over 4 years ago

  • Has duplicate Bug #15080: Service technique reports a warning after stopping a service added
Actions
Copy link
 #29

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.14 to 5.0.15
Actions
Copy link
 #30

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.15 to 5.0.16
Actions
Copy link
 #31

Updated by Alexis Mousset about 4 years ago

  • Target version changed from 5.0.16 to 5.0.17
Actions
Copy link
 #32

Updated by Vincent MEMBRÉ about 4 years ago

  • Target version changed from 5.0.17 to 5.0.18
Actions
Copy link
 #33

Updated by Vincent MEMBRÉ almost 4 years ago

  • Target version changed from 5.0.18 to 5.0.19
Actions
Copy link
 #34

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 5.0.19 to 5.0.20
Actions
Copy link
 #35

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 5.0.20 to 797
Actions
Copy link
 #36

Updated by Benoît PECCATTE almost 3 years ago

  • Target version changed from 797 to 6.1.14
Actions
Copy link
 #37

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 6.1.14 to 6.1.15
Actions
Copy link
 #38

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 6.1.15 to 6.1.16
Actions
Copy link
 #39

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.16 to 6.1.17
Actions
Copy link
 #40

Updated by Benoît PECCATTE over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions
Copy link
 #41

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.17 to 6.1.18
Actions
Copy link
 #42

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.18 to 6.1.19
Actions
Copy link
 #43

Updated by François ARMAND about 2 years ago

  • Tracker changed from Bug to Architecture
  • Severity deleted (Minor - inconvenience | misleading | easy workaround)
  • User visibility deleted (Operational - other Techniques | Technique editor | Rudder settings)
  • Priority deleted (0)
Actions
Copy link
 #44

Updated by Vincent MEMBRÉ about 2 years ago

  • Target version changed from 6.1.19 to 6.1.20
Actions
Copy link
 #45

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 6.1.20 to 6.1.21
Actions
Copy link
 #46

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 6.1.21 to old 6.1 issues to relocate
Actions
Copy link
 #47

Updated by Alexis Mousset about 1 year ago

  • Target version changed from old 6.1 issues to relocate to 8.0.0~alpha1
Actions
Copy link
 #48

Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 8.0.0~alpha1 to 8.0.0~beta1
Actions
Copy link
 #49

Updated by Alexis Mousset 9 months ago

  • Target version changed from 8.0.0~beta1 to 8.1.0~alpha1
Actions
Copy link
 #50

Updated by Alexis Mousset 8 months ago

  • Status changed from New to Resolved

we can now disable reporting

Actions
Copy link

Also available in: Atom PDF